Libguestfs - Aug 2018 - [PATCH] v2v: Add --mac option to machine-readable

Patch fe1a8866 added --mac option that allows mapping bridges/networks
based on the MAC address. It would be nice to have that listed in
machine-readable output

Signed-off-by: Tomáš Golembiovský <tgolembi@redhat.com>
---
 v2v/cmdline.ml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/v2v/cmdline.ml b/v2v/cmdline.ml
index 88cb67bbb..5b2df3555 100644
--- a/v2v/cmdline.ml
+++ b/v2v/cmdline.ml
@@ -347,6 +347,7 @@ read the man page virt-v2v(1).
     printf "vdsm-compat-option\n";
     printf "in-place\n";
     printf "io/oo\n";
+    printf "mac-option\n";
     List.iter (printf "input:%s\n") (Modules_list.input_modules ());
     List.iter (printf "output:%s\n") (Modules_list.output_modules
());
     List.iter (printf "convert:%s\n") (Modules_list.convert_modules
());
-- 
2.18.0

On Tuesday, 7 August 2018 14:03:07 CEST Tomáš Golembiovský
wrote:
> Patch fe1a8866 added --mac option that allows mapping bridges/networks
> based on the MAC address. It would be nice to have that listed in
> machine-readable output
> 
> Signed-off-by: Tomáš Golembiovský <tgolembi@redhat.com>
> ---
>  v2v/cmdline.ml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/v2v/cmdline.ml b/v2v/cmdline.ml
> index 88cb67bbb..5b2df3555 100644
> --- a/v2v/cmdline.ml
> +++ b/v2v/cmdline.ml
> @@ -347,6 +347,7 @@ read the man page virt-v2v(1).
>      printf "vdsm-compat-option\n";
>      printf "in-place\n";
>      printf "io/oo\n";
> +    printf "mac-option\n";
>      List.iter (printf "input:%s\n") (Modules_list.input_modules
());
>      List.iter (printf "output:%s\n")
(Modules_list.output_modules ());
>      List.iter (printf "convert:%s\n")
(Modules_list.convert_modules ());
Make sense, I will push it soon.

Thanks,
-- 
Pino Toscano

On Tue, Aug 07, 2018 at 02:03:07PM +0200, Tomáš Golembiovský
wrote:
> Patch fe1a8866 added --mac option that allows mapping bridges/networks
> based on the MAC address. It would be nice to have that listed in
> machine-readable output
Yes this is a good idea.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-p2v converts physical machines to virtual machines.  Boot with a
live CD or over the network (PXE) and turn machines into KVM guests.
http://libguestfs.org/virt-v2v