Richard W.M. Jones
2018-Jul-09 08:14 UTC
[Libguestfs] [PATCH] v2v: oVirt changed the ResourceType for QXL video devices (RHBZ#1598715).
See: https://bugzilla.redhat.com/show_bug.cgi?id=1598715#c5 --- v2v/create_ovf.ml | 2 +- v2v/test-v2v-o-rhv.ovf.expected | 2 +- v2v/test-v2v-o-vdsm-options.ovf.expected | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/v2v/create_ovf.ml b/v2v/create_ovf.ml index b2a240907..f5f29cdc4 100644 --- a/v2v/create_ovf.ml +++ b/v2v/create_ovf.ml @@ -648,7 +648,7 @@ let rec create_ovf source targets guestcaps inspect e "Item" [] [ e "rasd:Caption" [] [PCData "Graphical Controller"]; e "rasd:InstanceId" [] [PCData (uuidgen ())]; - e "rasd:ResourceType" [] [PCData "20"]; + e "rasd:ResourceType" [] [PCData "32768"]; e "Type" [] [PCData "video"]; e "rasd:VirtualQuantity" [] [PCData "1"]; e "rasd:Device" [] [PCData "qxl"]; diff --git a/v2v/test-v2v-o-rhv.ovf.expected b/v2v/test-v2v-o-rhv.ovf.expected index 7bcc456c5..2f1032b1f 100644 --- a/v2v/test-v2v-o-rhv.ovf.expected +++ b/v2v/test-v2v-o-rhv.ovf.expected @@ -56,7 +56,7 @@ <Item> <rasd:Caption>Graphical Controller</rasd:Caption> <rasd:InstanceId>#UUID#</rasd:InstanceId> - <rasd:ResourceType>20</rasd:ResourceType> + <rasd:ResourceType>32768</rasd:ResourceType> <Type>video</Type> <rasd:VirtualQuantity>1</rasd:VirtualQuantity> <rasd:Device>qxl</rasd:Device> diff --git a/v2v/test-v2v-o-vdsm-options.ovf.expected b/v2v/test-v2v-o-vdsm-options.ovf.expected index c1282c19b..abaf37e54 100644 --- a/v2v/test-v2v-o-vdsm-options.ovf.expected +++ b/v2v/test-v2v-o-vdsm-options.ovf.expected @@ -56,7 +56,7 @@ <Item> <rasd:Caption>Graphical Controller</rasd:Caption> <rasd:InstanceId>#UUID#</rasd:InstanceId> - <rasd:ResourceType>20</rasd:ResourceType> + <rasd:ResourceType>32768</rasd:ResourceType> <Type>video</Type> <rasd:VirtualQuantity>1</rasd:VirtualQuantity> <rasd:Device>qxl</rasd:Device> -- 2.17.1
Tomáš Golembiovský
2018-Jul-12 08:55 UTC
Re: [Libguestfs] [PATCH] v2v: oVirt changed the ResourceType for QXL video devices (RHBZ#1598715).
On Mon, 9 Jul 2018 09:14:28 +0100 "Richard W.M. Jones" <rjones@redhat.com> wrote:> See: > https://bugzilla.redhat.com/show_bug.cgi?id=1598715#c5 > --- > v2v/create_ovf.ml | 2 +- > v2v/test-v2v-o-rhv.ovf.expected | 2 +- > v2v/test-v2v-o-vdsm-options.ovf.expected | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-)LGTM
Seemingly Similar Threads
- [PATCH 1/2] Revert "v2v: oVirt changed the ResourceType for QXL video devices (RHBZ#1598715)."
- [PATCH 2/2] v2v: change QXL ResourceType in OVirt flavour (RHBZ#1598715)
- [PATCH 1/3] v2v: tests: check generated OVF
- [PATCH] v2v: OVF: Set <Origin/> field correctly based on source hypervisor.
- [PATCH v2 5/5] v2v: update tests to match changes in OVA import