Nir Soffer
2018-Jun-25 17:56 UTC
[Libguestfs] [PATCH v2] v2v: rhv-upload-plugin: Fix name error
"http" and "transfer" variables were missing in
emulate_zero, so the
code would fail with NameError. This can happen only when communicating
with old imageio versions not supporting the "zero" feature.
Testing with qemu-img 2.12 show that we never send emulated zero request
because of the highestwrite mechanism, but it can break with older
qemu-img-rhev used on RHEL.
---
v2v/rhv-upload-plugin.py | 3 +++
1 file changed, 3 insertions(+)
diff --git a/v2v/rhv-upload-plugin.py b/v2v/rhv-upload-plugin.py
index 2eec375f7..10887c031 100644
--- a/v2v/rhv-upload-plugin.py
+++ b/v2v/rhv-upload-plugin.py
@@ -338,6 +338,9 @@ def zero(h, count, offset, may_trim):
r.read()
def emulate_zero(h, count, offset):
+ http = h['http']
+ transfer = h['transfer']
+
# qemu-img convert starts by trying to zero/trim the whole device.
# Since we've just created a new disk it's safe to ignore these
# requests as long as they are smaller than the highest write seen.
--
2.17.1
Richard W.M. Jones
2018-Jun-25 18:10 UTC
Re: [Libguestfs] [PATCH v2] v2v: rhv-upload-plugin: Fix name error
Thanks, I pushed this and the other patch. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-builder quickly builds VMs from scratch http://libguestfs.org/virt-builder.1.html
Possibly Parallel Threads
- [PATCH] v2v: rhv-upload-plugin: Fix name error
- Re: [PATCH] v2v: rhv-upload-plugin: Fix name error
- [PATCH v2] v2v: -o rhv-upload: Log full imageio response on failure.
- Re: [Qemu-block] v2v: -o rhv-upload: Long time spent zeroing the disk
- Re: [PATCH] v2v: rhv-upload-plugin: Remove unneeded auth