Pino Toscano
2018-May-23 08:27 UTC
Re: [Libguestfs] [PATCH] lib: Increase default memory assigned to the appliance.
On Wednesday, 16 May 2018 14:43:09 CEST Richard W.M. Jones wrote:> With recent Linux kernels, adding and partitioning 255 disks causes > the appliance to run out of memory. This causes a test failure in > tests/disks/test-255-disks.sh. This change gives the appliance enough > memory to complete the test.TBH raising the amount of memory only for those tests is the solution IMHO, since they are very corner cases, and thus it makes sense for them to require extra work. In any case, the current default of memory seems fine for the majority of the use cases, so I'd delay the default change only if strictly needed to work in "usual workloads". -- Pino Toscano
Nikolay Ivanets
2018-May-23 08:48 UTC
Re: [Libguestfs] [PATCH] lib: Increase default memory assigned to the appliance.
I wonder why not to set required amount of memory using guestfs_set_memsize or setting LIBGUESTFS_MEMSIZE environment variable just for this test? -- +380979184774 Mykola Ivanets ср, 23 трав. 2018 о 11:28 Pino Toscano <ptoscano@redhat.com> пише:> On Wednesday, 16 May 2018 14:43:09 CEST Richard W.M. Jones wrote: > > With recent Linux kernels, adding and partitioning 255 disks causes > > the appliance to run out of memory. This causes a test failure in > > tests/disks/test-255-disks.sh. This change gives the appliance enough > > memory to complete the test. > > TBH raising the amount of memory only for those tests is the solution > IMHO, since they are very corner cases, and thus it makes sense for > them to require extra work. In any case, the current default of memory > seems fine for the majority of the use cases, so I'd delay the default > change only if strictly needed to work in "usual workloads". > > -- > Pino Toscano_______________________________________________ > Libguestfs mailing list > Libguestfs@redhat.com > https://www.redhat.com/mailman/listinfo/libguestfs
Pino Toscano
2018-May-23 09:28 UTC
Re: [Libguestfs] [PATCH] lib: Increase default memory assigned to the appliance.
On Wednesday, 23 May 2018 10:48:22 CEST Nikolay Ivanets wrote:> I wonder why not to set required amount of memory using guestfs_set_memsize > or setting LIBGUESTFS_MEMSIZE environment variable just for this test?That was Rich's v1: https://www.redhat.com/archives/libguestfs/2018-May/msg00082.html -- Pino Toscano
Possibly Parallel Threads
- Re: [PATCH] lib: Increase default memory assigned to the appliance.
- Re: Guestfish command - "copy-out" not working for symbolic links
- Re: Guestfish command - "copy-out" not working for symbolic links
- Re: Guestfish command - "copy-out" not working for symbolic links
- Re: Guestfish command - "copy-out" not working for symbolic links