Libguestfs - May 2018 - [PATCH] v2v: Map Windows Server 2012 R2 x86-64 to ovirt ID 25.

I also checked the other ovirt IDs and they all seem to be correct,
although this mapping to internal oVirt database IDs is by its nature
very fragile and will require constant maintenance.

Rich.

This was the apparent cause of a conversion failure:

  "Non Linux Operating systems must have the Single PCI option
  disabled"

Thanks to Michal Skrivanek for diagnosis.

Fixes commit 593a19cc86cfa8f24c66518c8ba21222550b066a.
---
 v2v/create_ovf.ml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/v2v/create_ovf.ml b/v2v/create_ovf.ml
index c29b8421c..190cf8bed 100644
--- a/v2v/create_ovf.ml
+++ b/v2v/create_ovf.ml
@@ -418,7 +418,7 @@ and get_ovirt_osid = function
 
   | { i_type = "windows"; i_major_version = 6; i_minor_version = 3;
       i_arch = "x86_64" } ->
-    23
+    25
 
   | { i_type = "windows"; i_major_version = 10; i_minor_version = 0;
       i_arch = "i386" } ->
-- 
2.16.2

> On 1 May 2018, at 12:34, Richard W.M. Jones <rjones@redhat.com>
wrote:
> 
> This was the apparent cause of a conversion failure:
ah, no, that’s not actually the reason. It is not a correct id, but it’s close
enough (still a valid Windows id), there is a bug in the ovirt-engine import[1]

It’s a simple enough fix, but delivering it is a bit challenging. We can only do
the first z-stream after RHV 4.2 GA

There are likely other workaround possible, maybe setting it to false at the
same time as we are currently setting the description would be enough. Something
like adding
“<vm>...<display><single_qxl_pci>false</single_qxl_pci>
</display></vm>"

Thanks,
michal

[1] https://bugzilla.redhat.com/show_bug.cgi?id=1573462
> 
>  "Non Linux Operating systems must have the Single PCI option
>  disabled"
> 
> Thanks to Michal Skrivanek for diagnosis.
> 
> Fixes commit 593a19cc86cfa8f24c66518c8ba21222550b066a.
> ---
> v2v/create_ovf.ml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/v2v/create_ovf.ml b/v2v/create_ovf.ml
> index c29b8421c..190cf8bed 100644
> --- a/v2v/create_ovf.ml
> +++ b/v2v/create_ovf.ml
> @@ -418,7 +418,7 @@ and get_ovirt_osid = function
> 
>   | { i_type = "windows"; i_major_version = 6; i_minor_version =
3;
>       i_arch = "x86_64" } ->
> -    23
> +    25
> 
>   | { i_type = "windows"; i_major_version = 10; i_minor_version =
0;
>       i_arch = "i386" } ->
> -- 
> 2.16.2
>