Tomáš Golembiovský
2018-Apr-22 20:57 UTC
[Libguestfs] [PATCH 0/1] Install RHV tools with -o rhv-upload
It seems we're missing this in rhv-upload. Unfortunately I'm not able to test it at the moment. Tomáš Golembiovský (1): v2v: -o rhv-upload: install RHV tools v2v/output_rhv_upload.ml | 3 +++ 1 file changed, 3 insertions(+) -- 2.17.0
Tomáš Golembiovský
2018-Apr-22 20:57 UTC
[Libguestfs] [PATCH 1/1] v2v: -o rhv-upload: install RHV tools
Signed-off-by: Tomáš Golembiovský <tgolembi@redhat.com> --- v2v/output_rhv_upload.ml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/v2v/output_rhv_upload.ml b/v2v/output_rhv_upload.ml index dc0d96d53..0152b8d5a 100644 --- a/v2v/output_rhv_upload.ml +++ b/v2v/output_rhv_upload.ml @@ -247,6 +247,9 @@ object method supported_firmware = [ TargetBIOS ] + (* rhev-apt.exe will be installed (if available). *) + method install_rhev_apt = true + method prepare_targets source targets let output_name = source.s_name in let json_params -- 2.17.0
Richard W.M. Jones
2018-Apr-23 08:35 UTC
Re: [Libguestfs] [PATCH 1/1] v2v: -o rhv-upload: install RHV tools
On Sun, Apr 22, 2018 at 10:57:55PM +0200, Tomáš Golembiovský wrote:> Signed-off-by: Tomáš Golembiovský <tgolembi@redhat.com> > --- > v2v/output_rhv_upload.ml | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/v2v/output_rhv_upload.ml b/v2v/output_rhv_upload.ml > index dc0d96d53..0152b8d5a 100644 > --- a/v2v/output_rhv_upload.ml > +++ b/v2v/output_rhv_upload.ml > @@ -247,6 +247,9 @@ object > > method supported_firmware = [ TargetBIOS ] > > + (* rhev-apt.exe will be installed (if available). *) > + method install_rhev_apt = true > + > method prepare_targets source targets > let output_name = source.s_name in > let json_paramsACK, good catch. I'll push this one in a minute with a small modification to the commit message so it references RHBZ#1561828. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into KVM guests. http://libguestfs.org/virt-v2v
Reasonably Related Threads
- [PATCH 0/1] Install RHV tools with -o rhv-upload
- [v2v PATCH 1/2] Add back guestcaps as parameter of output#prepare_targets
- [PATCH] v2v: -o rhv-upload: add -oo rhv-disk-uuid option
- [v2v PATCH 2/2] -o rhv-upload: check guest arch with cluster
- [PATCH v2 3/3] rhv-upload: Support qcow2 disk format