Richard W.M. Jones
2018-Feb-28 15:04 UTC
[Libguestfs] [PATCH] v2v: rhv: Fix virtio-rng and memballoon OVF fragment for RHV.
Without this extra element, oVirt will crash with a Java NullPointerException (see https://bugzilla.redhat.com/1550123). Fixes commit dac5fc53acdd1e51be2957c67e1e063e2132e680. --- v2v/create_ovf.ml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/v2v/create_ovf.ml b/v2v/create_ovf.ml index f5e34d79f..87245fdc8 100644 --- a/v2v/create_ovf.ml +++ b/v2v/create_ovf.ml @@ -444,6 +444,9 @@ let rec create_ovf source targets guestcaps inspect e "rasd:ResourceType" [] [PCData "0"]; e "Type" [] [PCData "rng"]; e "Device" [] [PCData "virtio"]; + e "SpecParams" [] [ + e "source" [] [PCData "urandom"] + ] ] ); if guestcaps.gcaps_virtio_balloon then @@ -454,6 +457,9 @@ let rec create_ovf source targets guestcaps inspect e "rasd:ResourceType" [] [PCData "0"]; e "Type" [] [PCData "balloon"]; e "Device" [] [PCData "memballoon"]; + e "SpecParams" [] [ + e "model" [] [PCData "virtio"] + ] ] ); -- 2.13.2
Tomáš Golembiovský
2018-Feb-28 15:19 UTC
Re: [Libguestfs] [PATCH] v2v: rhv: Fix virtio-rng and memballoon OVF fragment for RHV.
On Wed, 28 Feb 2018 15:04:23 +0000 "Richard W.M. Jones" <rjones@redhat.com> wrote:> Without this extra element, oVirt will crash with a Java > NullPointerException (see https://bugzilla.redhat.com/1550123). > > Fixes commit dac5fc53acdd1e51be2957c67e1e063e2132e680. > --- > v2v/create_ovf.ml | 6 ++++++ > 1 file changed, 6 insertions(+) >LGTM
Possibly Parallel Threads
- Re: [PATCH v3 1/6] v2v: rhv: Fix virtio-rng and memballoon OVF fragment for RHV.
- Re: [PATCH v3 1/6] v2v: rhv: Fix virtio-rng and memballoon OVF fragment for RHV.
- [PATCH v3 1/6] v2v: rhv: Fix virtio-rng and memballoon OVF fragment for RHV.
- [PATCH v2] v2v: ovf: Add virtio-rng and memory balloon device
- Re: [PATCH] v2v: ovf: Add virtio-rng and memory balloon device