Richard W.M. Jones
2017-Jun-09 11:56 UTC
[Libguestfs] [PATCH] daemon: ldm: Use CLEANUP_FREE on list of static strings.
This likely causes a double-free in the ‘ldmtool_scan_devices’ API.
---
daemon/ldm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/daemon/ldm.c b/daemon/ldm.c
index 8ad2fb33b..7753b0d82 100644
--- a/daemon/ldm.c
+++ b/daemon/ldm.c
@@ -316,7 +316,7 @@ do_ldmtool_scan_devices (char * const * devices)
{
char **ret;
size_t i, nr_devices;
- CLEANUP_FREE_STRING_LIST const char **argv = NULL;
+ CLEANUP_FREE const char **argv = NULL;
int r;
CLEANUP_FREE char *out = NULL, *err = NULL;
--
2.13.0
Pino Toscano
2017-Jun-09 12:29 UTC
Re: [Libguestfs] [PATCH] daemon: ldm: Use CLEANUP_FREE on list of static strings.
On Friday, 9 June 2017 13:56:19 CEST Richard W.M. Jones wrote:> This likely causes a double-free in the ‘ldmtool_scan_devices’ API. > ---As mentioned on IRC as well, LGTM. Thanks, -- Pino Toscano
Possibly Parallel Threads
- [PATCH v7 13/13] daemon: Link guestfsd with libutils.
- [PATCH] listfs: If LDM not available, don't inhibit partition detection (RHBZ#1079182).
- [PATCH] daemon: ldm: avoid manual free()
- [PATCH 19/27] daemon: Reimplement ‘list_filesystems’ API in the daemon, in OCaml.
- Re: [PATCH] daemon: ldm: avoid manual free()