Tomáš Golembiovský
2017-Apr-13 16:49 UTC
[Libguestfs] [PATCH] v2v: ovf: store CPU model for oVirt
If CPU model is available store it in OVF for oVirt. This affects -o rhev and -o vdsm. Signed-off-by: Tomáš Golembiovský <tgolembi@redhat.com> --- v2v/create_ovf.ml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/v2v/create_ovf.ml b/v2v/create_ovf.ml index f5dc64753..9d7341696 100644 --- a/v2v/create_ovf.ml +++ b/v2v/create_ovf.ml @@ -306,6 +306,12 @@ let rec create_ovf source targets guestcaps inspect e "DefaultDisplayType" [] [PCData "1"]; ] in + (match source.s_cpu_model with + | None -> () + | Some model -> + push_back content_subnodes (e "CustomCpuName" [] [PCData model]) + ); + (* Add the <Origin/> element if we can. *) (match origin_of_source_hypervisor source.s_hypervisor with | None -> () -- 2.12.1
Richard W.M. Jones
2017-Apr-14 12:21 UTC
Re: [Libguestfs] [PATCH] v2v: ovf: store CPU model for oVirt
On Thu, Apr 13, 2017 at 06:49:33PM +0200, Tomáš Golembiovský wrote:> If CPU model is available store it in OVF for oVirt. This affects > -o rhev and -o vdsm. > > Signed-off-by: Tomáš Golembiovský <tgolembi@redhat.com> > --- > v2v/create_ovf.ml | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/v2v/create_ovf.ml b/v2v/create_ovf.ml > index f5dc64753..9d7341696 100644 > --- a/v2v/create_ovf.ml > +++ b/v2v/create_ovf.ml > @@ -306,6 +306,12 @@ let rec create_ovf source targets guestcaps inspect > e "DefaultDisplayType" [] [PCData "1"]; > ] in > > + (match source.s_cpu_model with > + | None -> () > + | Some model -> > + push_back content_subnodes (e "CustomCpuName" [] [PCData model]) > + ); > + > (* Add the <Origin/> element if we can. *) > (match origin_of_source_hypervisor source.s_hypervisor with > | None -> () > --Thanks - pushed. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://people.redhat.com/~rjones/virt-top
Maybe Matching Threads
- [PATCH v2] v2v: ovf: Add virtio-rng and memory balloon device
- [PATCH] v2v: ovf: add firmware and machine type element
- [PATCH] v2v: OVF: Set <Origin/> field correctly based on source hypervisor.
- [PATCH] v2v: ovf: Add virtio-rng and memory balloon device
- [PATCH 2/3] v2v: ovf: Create OVF more aligned with the standard