Libguestfs - Dec 2016 - [PATCH] tests: drop expected-failing btrfs_subvolume_show test

One of the tests for btrfs_subvolume_show tries to invoke it on the
toplevel subvolume, expecting its failure (since btrfs-progs used to not
be able to list that).  However, since v4.8.3 btrfs-progs can do that
(even if the data returned for that subvolume is limited/incomplete),
and thus this test fails because the API does not fail anymore.

Since we can consider that functionality working (for some kind of it),
then drop this test.
---
 generator/actions.ml | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/generator/actions.ml b/generator/actions.ml
index 77fca20..fb896f5 100644
--- a/generator/actions.ml
+++ b/generator/actions.ml
@@ -12545,10 +12545,6 @@ Get the default subvolume or snapshot of a filesystem
mounted at C<mountpoint>."
     proc_nr = Some 426;
     optional = Some "btrfs"; camel_name =
"BTRFSSubvolumeShow";
     tests = [
-      InitPartition, Always, TestLastFail (
-        [["mkfs_btrfs"; "/dev/sda1"; "";
""; "NOARG"; ""; "NOARG";
"NOARG"; ""; ""];
-         ["mount"; "/dev/sda1"; "/"];
-         ["btrfs_subvolume_show"; "/"]]), [];
       InitPartition, Always, TestRun (
         [["mkfs_btrfs"; "/dev/sda1"; "";
""; "NOARG"; ""; "NOARG";
"NOARG"; ""; ""];
          ["mount"; "/dev/sda1"; "/"];
-- 
2.7.4

On Wed, Dec 14, 2016 at 05:14:03PM +0100, Pino Toscano
wrote:
> One of the tests for btrfs_subvolume_show tries to invoke it on the
> toplevel subvolume, expecting its failure (since btrfs-progs used to not
> be able to list that).  However, since v4.8.3 btrfs-progs can do that
> (even if the data returned for that subvolume is limited/incomplete),
> and thus this test fails because the API does not fail anymore.
> 
> Since we can consider that functionality working (for some kind of it),
> then drop this test.
> ---
>  generator/actions.ml | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/generator/actions.ml b/generator/actions.ml
> index 77fca20..fb896f5 100644
> --- a/generator/actions.ml
> +++ b/generator/actions.ml
> @@ -12545,10 +12545,6 @@ Get the default subvolume or snapshot of a
filesystem mounted at C<mountpoint>."
>      proc_nr = Some 426;
>      optional = Some "btrfs"; camel_name =
"BTRFSSubvolumeShow";
>      tests = [
> -      InitPartition, Always, TestLastFail (
> -        [["mkfs_btrfs"; "/dev/sda1"; "";
""; "NOARG"; ""; "NOARG";
"NOARG"; ""; ""];
> -         ["mount"; "/dev/sda1"; "/"];
> -         ["btrfs_subvolume_show"; "/"]]), [];
>        InitPartition, Always, TestRun (
>          [["mkfs_btrfs"; "/dev/sda1"; "";
""; "NOARG"; ""; "NOARG";
"NOARG"; ""; ""];
>           ["mount"; "/dev/sda1"; "/"];
ACK.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-df lists disk usage of guests without needing to install any
software inside the virtual machine.  Supports Linux and Windows.
http://people.redhat.com/~rjones/virt-df/