Libguestfs - Dec 2016 - [PATCH] appliance: mount also /dev/pts

Tools could require the use of pseudo-terminals, so make sure we have
/dev/pts available in the appliance.  The "command" API already
bind-mounts it when running commands, so this is the only bit needed.
---
 appliance/init | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/appliance/init b/appliance/init
index e678e42..8be27a2 100755
--- a/appliance/init
+++ b/appliance/init
@@ -72,6 +72,8 @@ fi
 
 # devtmpfs is required since udev 176
 mount -t devtmpfs /dev /dev
+mkdir -p /dev/pts
+mount -t devpts /dev/pts /dev/pts
 
 if [[ $cmdline == *selinux=1* ]]; then
   mount -t selinuxfs none /sys/fs/selinux
-- 
2.7.4

On Tue, Dec 06, 2016 at 06:10:23PM +0100, Pino Toscano
wrote:
> Tools could require the use of pseudo-terminals, so make sure we have
> /dev/pts available in the appliance.  The "command" API already
> bind-mounts it when running commands, so this is the only bit needed.
> ---
>  appliance/init | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/appliance/init b/appliance/init
> index e678e42..8be27a2 100755
> --- a/appliance/init
> +++ b/appliance/init
> @@ -72,6 +72,8 @@ fi
>  
>  # devtmpfs is required since udev 176
>  mount -t devtmpfs /dev /dev
> +mkdir -p /dev/pts
> +mount -t devpts /dev/pts /dev/pts
>  
>  if [[ $cmdline == *selinux=1* ]]; then
>    mount -t selinuxfs none /sys/fs/selinux
Obvious bugfix, ACK.

Thanks, Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-builder quickly builds VMs from scratch
http://libguestfs.org/virt-builder.1.html