Libguestfs - Sep 2016 - Re: [PATCH] daemon: Use reply_with_error instead of *_perror for setfiles command.

Fixes commit 9d205f1c284a69390907120ca44f5c723fecc244.
---
 daemon/selinux-relabel.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/daemon/selinux-relabel.c b/daemon/selinux-relabel.c
index daafe9e..cfc4cf8 100644
--- a/daemon/selinux-relabel.c
+++ b/daemon/selinux-relabel.c
@@ -92,7 +92,7 @@ do_selinux_relabel (const char *specfile, const char *path,
   ADD_ARG (argv, i, NULL);
 
   if (commandv (NULL, &err, argv) == -1) {
-    reply_with_perror ("%s", err);
+    reply_with_error ("%s", err);
     return -1;
   }
 
-- 
2.7.4

On Friday, 9 September 2016 09:00:35 CEST Richard W.M. Jones
wrote:
> Fixes commit 9d205f1c284a69390907120ca44f5c723fecc244.
> ---
LGTM.

Thanks,
-- 
Pino Toscano

On Fri, Sep 09, 2016 at 10:41:10AM +0200, Pino Toscano
wrote:
> On Friday, 9 September 2016 09:00:35 CEST Richard W.M. Jones wrote:
> > Fixes commit 9d205f1c284a69390907120ca44f5c723fecc244.
> > ---
> 
> LGTM.
The background to this is:

  https://bugzilla.redhat.com/show_bug.cgi?id=1374232#c7

which is tricky to fix from within libguestfs.  Currently it
only appears to affect 3+ year old versions of RHEL 6.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-top is 'top' for virtual machines.  Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.
http://people.redhat.com/~rjones/virt-top