Richard W.M. Jones
2016-Jun-14 17:55 UTC
[Libguestfs] [PATCH] mllib: Use Unix.F_OK instead of plain F_OK.
Removes this warning:
File "common_utils.ml", line 826, characters 24-28:
Warning 40: F_OK was selected from type Unix.access_permission.
It is not visible in the current scope, and will not
be selected if the type becomes unknown.
---
mllib/common_utils.ml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mllib/common_utils.ml b/mllib/common_utils.ml
index 8e9f943..64bf3d3 100644
--- a/mllib/common_utils.ml
+++ b/mllib/common_utils.ml
@@ -823,7 +823,7 @@ let is_partition dev let major = Dev_t.major rdev in
let minor = Dev_t.minor rdev in
let path = sprintf "/sys/dev/block/%d:%d/partition" major minor
in
- Unix.access path [F_OK];
+ Unix.access path [Unix.F_OK];
true
)
with Unix.Unix_error _ -> false
--
2.7.4
Pino Toscano
2016-Jun-15 08:01 UTC
Re: [Libguestfs] [PATCH] mllib: Use Unix.F_OK instead of plain F_OK.
On Tuesday 14 June 2016 18:55:20 Richard W.M. Jones wrote:> Removes this warning: > > File "common_utils.ml", line 826, characters 24-28: > Warning 40: F_OK was selected from type Unix.access_permission. > It is not visible in the current scope, and will not > be selected if the type becomes unknown. > ---LGTM. -- Pino Toscano
Maybe Matching Threads
- [PATCH] mllib: Add isspace, triml, trimr and trim functions.
- [PATCH 2/3] mllib: expose disk decrypt functionalities
- [PATCH] mllib: Bind %identity C primitive to Common_utils.identity.
- [PATCH 4/5] mllib: move stringify_args from dib
- [PATCH v4 8/9] mllib: add do_mv helper function to Common_utils