Pino Toscano
2016-Jan-25 18:19 UTC
[Libguestfs] [PATCH] actions: expand partitions for btrfs_image test
Apparently with newer btrfs-progs (seen with 4.4) 100M are not enough
for a btrfs filesystem; hence double the size of the partitions
created in the test of btrfs_image, so now 200M are enough for btrfs.
---
generator/actions.ml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/generator/actions.ml b/generator/actions.ml
index 75d3fc5..9ea5736 100644
--- a/generator/actions.ml
+++ b/generator/actions.ml
@@ -12680,8 +12680,8 @@ This enable skinny metadata extent refs." };
tests = [
InitEmpty, Always, TestRun (
[["part_init"; "/dev/sda"; "mbr"];
- ["part_add"; "/dev/sda"; "p";
"64"; "204799"];
- ["part_add"; "/dev/sda"; "p";
"204800"; "409599"];
+ ["part_add"; "/dev/sda"; "p";
"64"; "409599"];
+ ["part_add"; "/dev/sda"; "p";
"409600"; "819199"];
["mkfs_btrfs"; "/dev/sda1"; "";
""; "NOARG"; ""; "NOARG";
"NOARG"; ""; ""];
["mkfs_btrfs"; "/dev/sda2"; "";
""; "NOARG"; ""; "NOARG";
"NOARG"; ""; ""];
["mount"; "/dev/sda1"; "/"];
--
2.5.0
Richard W.M. Jones
2016-Jan-25 18:24 UTC
Re: [Libguestfs] [PATCH] actions: expand partitions for btrfs_image test
On Mon, Jan 25, 2016 at 07:19:52PM +0100, Pino Toscano wrote:> Apparently with newer btrfs-progs (seen with 4.4) 100M are not enough > for a btrfs filesystem; hence double the size of the partitions > created in the test of btrfs_image, so now 200M are enough for btrfs. > --- > generator/actions.ml | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/generator/actions.ml b/generator/actions.ml > index 75d3fc5..9ea5736 100644 > --- a/generator/actions.ml > +++ b/generator/actions.ml > @@ -12680,8 +12680,8 @@ This enable skinny metadata extent refs." }; > tests = [ > InitEmpty, Always, TestRun ( > [["part_init"; "/dev/sda"; "mbr"]; > - ["part_add"; "/dev/sda"; "p"; "64"; "204799"]; > - ["part_add"; "/dev/sda"; "p"; "204800"; "409599"]; > + ["part_add"; "/dev/sda"; "p"; "64"; "409599"]; > + ["part_add"; "/dev/sda"; "p"; "409600"; "819199"]; > ["mkfs_btrfs"; "/dev/sda1"; ""; ""; "NOARG"; ""; "NOARG"; "NOARG"; ""; ""]; > ["mkfs_btrfs"; "/dev/sda2"; ""; ""; "NOARG"; ""; "NOARG"; "NOARG"; ""; ""]; > ["mount"; "/dev/sda1"; "/"];ACK. - - - Also if you run any of the btrfs tests on Fedora/aarch64 (where page size is 64K), almost all of them fail. I didn't look into this too deeply yet. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-df lists disk usage of guests without needing to install any software inside the virtual machine. Supports Linux and Windows. http://people.redhat.com/~rjones/virt-df/