Richard, I put an #ifdef around the logic in py_guestfs_mount_9p and py_guestfs_list_9p, I.e. Left the signatures but the functions just return a a NULL PyObject. It now builds and installs with pip. Thanks for all your help most appreciated. Is there a better way to do this?, #ifdefs always seem a little hacky. Regards John On 9/14/15, 12:47 PM, "Richard W.M. Jones" <rjones@redhat.com> wrote:>On Mon, Sep 14, 2015 at 07:06:48PM +0000, John McDowall wrote: >> Richard, >> >> It is looking better, but still getting error - see attached log. >> >> I removed all installed packages and yum installed libguestfs >> libguestfs-devel (1.28.1) >> >> Then reset my git repository to 1.28.1 and then >> >> $ make clean >> $ ./autogen.sh --disable-erlang --disable-perl --disable-lua >>--disable-ruby >> $ make >> $ make -C python sdist >> $ cd python/dist >> $ sudo pip install guestfs-1.28.1.tar.gz > >That's pretty close to working. We remove the *_9p functions in RHEL >because they are not supportable, so if you edit guestfs-py.c by hand >to remove those bindings it may work. > >Rich. > >-- >Richard Jones, Virtualization Group, Red Hat >https://urldefense.proofpoint.com/v2/url?u=http-3A__people.redhat.com_-7Er >jones&d=AwIBAg&c=V9IgWpI5PvzTw83UyHGVSoW3Uc1MFWe5J8PTfkrzVSo&r=vZ6VUDaavDp >fOdPQrz1ED54jEjvAE36A8TVJroVlrOQ&m=rMKmgqBnzomK9gZ2IFeCMAUQoOb0CIXOuHL0unS >akbw&s=Wd1vKCyHdDlv2mC5G5ESdLBSfiHAPPD971EH870rIBc&e>Read my programming and virtualization blog: >https://urldefense.proofpoint.com/v2/url?u=http-3A__rwmj.wordpress.com&d=A >wIBAg&c=V9IgWpI5PvzTw83UyHGVSoW3Uc1MFWe5J8PTfkrzVSo&r=vZ6VUDaavDpfOdPQrz1E >D54jEjvAE36A8TVJroVlrOQ&m=rMKmgqBnzomK9gZ2IFeCMAUQoOb0CIXOuHL0unSakbw&s=FN >5LMvtC9ufnfnGV0YnkBv3OzG8wO768Y9b4VgxJ6W0&e>Fedora Windows cross-compiler. Compile Windows programs, test, and >build Windows installers. Over 100 libraries supported. >https://urldefense.proofpoint.com/v2/url?u=http-3A__fedoraproject.org_wiki >_MinGW&d=AwIBAg&c=V9IgWpI5PvzTw83UyHGVSoW3Uc1MFWe5J8PTfkrzVSo&r=vZ6VUDaavD >pfOdPQrz1ED54jEjvAE36A8TVJroVlrOQ&m=rMKmgqBnzomK9gZ2IFeCMAUQoOb0CIXOuHL0un >Sakbw&s=B4XzrgRkrzOTaaxSxzhN0kt7_cwxFKtIPsRdaEualL0&e=
On Mon, Sep 14, 2015 at 09:45:16PM +0000, John McDowall wrote:> Richard, > > I put an #ifdef around the logic in py_guestfs_mount_9p and > py_guestfs_list_9p, I.e. Left the signatures but the functions just return > a a NULL PyObject. It now builds and installs with pip. > Thanks for all your help most appreciated. > > Is there a better way to do this?, #ifdefs always seem a little hacky.Actually I was wondering why the python-libguestfs package from RHEL doesn't work for you. I don't use Python much myself, but is there some benefit to using PIP? In answer to your question, yes the #ifdefs are hacky. We need to fix the bug I mentioned before properly. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-builder quickly builds VMs from scratch http://libguestfs.org/virt-builder.1.html
Richard, The Redhat yum package works for global settings. Just in the habit of using Python virtual environments, keeps python packages separate and easier to track which packages are required in by an application. Regards John On 9/14/15, 3:08 PM, "Richard W.M. Jones" <rjones@redhat.com> wrote:>On Mon, Sep 14, 2015 at 09:45:16PM +0000, John McDowall wrote: >> Richard, >> >> I put an #ifdef around the logic in py_guestfs_mount_9p and >> py_guestfs_list_9p, I.e. Left the signatures but the functions just >>return >> a a NULL PyObject. It now builds and installs with pip. >> Thanks for all your help most appreciated. >> >> Is there a better way to do this?, #ifdefs always seem a little hacky. > >Actually I was wondering why the python-libguestfs package from RHEL >doesn't work for you. I don't use Python much myself, but is there >some benefit to using PIP? > >In answer to your question, yes the #ifdefs are hacky. We need to fix >the bug I mentioned before properly. > >Rich. > >-- >Richard Jones, Virtualization Group, Red Hat >https://urldefense.proofpoint.com/v2/url?u=http-3A__people.redhat.com_-7Er >jones&d=AwIBAg&c=V9IgWpI5PvzTw83UyHGVSoW3Uc1MFWe5J8PTfkrzVSo&r=vZ6VUDaavDp >fOdPQrz1ED54jEjvAE36A8TVJroVlrOQ&m=ySvUEe1JrJiYtWMPHeBxoFT3Fy5n6Y7C6VLhA5q >T-oI&s=otrOnAZCkauO1XDBmknezc4ZTBEpL1FJDhvbsqFLfqc&e>Read my programming and virtualization blog: >https://urldefense.proofpoint.com/v2/url?u=http-3A__rwmj.wordpress.com&d=A >wIBAg&c=V9IgWpI5PvzTw83UyHGVSoW3Uc1MFWe5J8PTfkrzVSo&r=vZ6VUDaavDpfOdPQrz1E >D54jEjvAE36A8TVJroVlrOQ&m=ySvUEe1JrJiYtWMPHeBxoFT3Fy5n6Y7C6VLhA5qT-oI&s=n5 >pPDk_xnoFvA6LrNUUrV_2BsKpoh6jeAlfxneTB-gw&e>virt-builder quickly builds VMs from scratch >https://urldefense.proofpoint.com/v2/url?u=http-3A__libguestfs.org_virt-2D >builder.1.html&d=AwIBAg&c=V9IgWpI5PvzTw83UyHGVSoW3Uc1MFWe5J8PTfkrzVSo&r=vZ >6VUDaavDpfOdPQrz1ED54jEjvAE36A8TVJroVlrOQ&m=ySvUEe1JrJiYtWMPHeBxoFT3Fy5n6Y >7C6VLhA5qT-oI&s=2YvdPNHgyitmaZNAbYnIUVrrpAwtsARK4G-hZ4jwNwI&e=