Pino Toscano
2015-Jun-18 11:49 UTC
[Libguestfs] [PATCH] btrfs: fix leak in btrfs_scrub_status
Properly free the output buffer. --- daemon/btrfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/daemon/btrfs.c b/daemon/btrfs.c index 2f875ae..050bf18 100644 --- a/daemon/btrfs.c +++ b/daemon/btrfs.c @@ -1814,7 +1814,7 @@ do_btrfs_scrub_status (const char *path) CLEANUP_FREE char *path_buf = NULL; CLEANUP_FREE char *err = NULL; CLEANUP_FREE_STRING_LIST char **lines = NULL; - char *out; + CLEANUP_FREE char *out = NULL; int r; guestfs_int_btrfsscrub *ret; -- 2.1.0
Richard W.M. Jones
2015-Jun-18 12:52 UTC
Re: [Libguestfs] [PATCH] btrfs: fix leak in btrfs_scrub_status
On Thu, Jun 18, 2015 at 01:49:35PM +0200, Pino Toscano wrote:> Properly free the output buffer. > --- > daemon/btrfs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/daemon/btrfs.c b/daemon/btrfs.c > index 2f875ae..050bf18 100644 > --- a/daemon/btrfs.c > +++ b/daemon/btrfs.c > @@ -1814,7 +1814,7 @@ do_btrfs_scrub_status (const char *path) > CLEANUP_FREE char *path_buf = NULL; > CLEANUP_FREE char *err = NULL; > CLEANUP_FREE_STRING_LIST char **lines = NULL; > - char *out; > + CLEANUP_FREE char *out = NULL; > int r; > guestfs_int_btrfsscrub *ret;ACK. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-df lists disk usage of guests without needing to install any software inside the virtual machine. Supports Linux and Windows. http://people.redhat.com/~rjones/virt-df/
Reasonably Related Threads
- [PATCH v2] btrfs: use CLEANUP_FREE_STRING_LIST for list free
- [PATCH v3 0/3] btrfs: use CLEANUP_FREE_STRING_LIST for list free
- [PATCH v4 0/3] btrfs: use CLEANUP_FREE_STRING_LIST for list free
- [PATCH v2 0/2] add btrfs_balance_status and btrfs_scrub_status
- [PATCH v5 0/2] add btrfs_balance_status and btrfs_scrub_status