Libguestfs - Nov 2014 - Re: [PATCH 1/6] btrfs: correct words about subvolume and snapshot

On Friday 21 November 2014 13:17:55 Hu Tao wrote:
> btrfs_subvolume_create creates only subvolumes. btrfs_subvolume_delete
> deletes subvolumes or snapshots.
> 
> Signed-off-by: Hu Tao <hutao@cn.fujitsu.com>
> ---
>  generator/actions.ml | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/generator/actions.ml b/generator/actions.ml
> index 89332f5..fe492e6 100644
> --- a/generator/actions.ml
> +++ b/generator/actions.ml
> @@ -10248,19 +10248,19 @@ of the snapshot, in the form
> C</path/to/dest/name>." }; ["btrfs_subvolume_create";
"/test1"];
>           ["btrfs_subvolume_delete"; "/test1"]]), []
>      ];
> -    shortdesc = "delete a btrfs snapshot";
> +    shortdesc = "delete a btrfs subvolume or snapshot";
>      longdesc = "\
> -Delete the named btrfs subvolume." };
> +Delete the named btrfs subvolume or snapshot." };
> 
>    { defaults with
>      name = "btrfs_subvolume_create";
>      style = RErr, [Pathname "dest"], [];
>      proc_nr = Some 324;
>      optional = Some "btrfs"; camel_name =
"BTRFSSubvolumeCreate";
> -    shortdesc = "create a btrfs snapshot";
> +    shortdesc = "create a btrfs subvolume";
>      longdesc = "\
>  Create a btrfs subvolume.  The C<dest> argument is the destination
> -directory and the name of the snapshot, in the form
> C</path/to/dest/name>." }; +directory and the name of the
subvolume,
> in the form C</path/to/dest/name>." };
> 
>    { defaults with
>      name = "btrfs_subvolume_list";
LGTM.

-- 
Pino Toscano

On Fri, Nov 21, 2014 at 11:35:11AM +0100, Pino Toscano
wrote:
> On Friday 21 November 2014 13:17:55 Hu Tao wrote:
> > btrfs_subvolume_create creates only subvolumes. btrfs_subvolume_delete
> > deletes subvolumes or snapshots.
> > 
> > Signed-off-by: Hu Tao <hutao@cn.fujitsu.com>
> > ---
> >  generator/actions.ml | 8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> > 
> > diff --git a/generator/actions.ml b/generator/actions.ml
> > index 89332f5..fe492e6 100644
> > --- a/generator/actions.ml
> > +++ b/generator/actions.ml
> > @@ -10248,19 +10248,19 @@ of the snapshot, in the form
> > C</path/to/dest/name>." };
["btrfs_subvolume_create"; "/test1"];
> >           ["btrfs_subvolume_delete"; "/test1"]]),
[]
> >      ];
> > -    shortdesc = "delete a btrfs snapshot";
> > +    shortdesc = "delete a btrfs subvolume or snapshot";
> >      longdesc = "\
> > -Delete the named btrfs subvolume." };
> > +Delete the named btrfs subvolume or snapshot." };
> > 
> >    { defaults with
> >      name = "btrfs_subvolume_create";
> >      style = RErr, [Pathname "dest"], [];
> >      proc_nr = Some 324;
> >      optional = Some "btrfs"; camel_name =
"BTRFSSubvolumeCreate";
> > -    shortdesc = "create a btrfs snapshot";
> > +    shortdesc = "create a btrfs subvolume";
> >      longdesc = "\
> >  Create a btrfs subvolume.  The C<dest> argument is the
destination
> > -directory and the name of the snapshot, in the form
> > C</path/to/dest/name>." }; +directory and the name of the
subvolume,
> > in the form C</path/to/dest/name>." };
> > 
> >    { defaults with
> >      name = "btrfs_subvolume_list";
> 
> LGTM.
This means I can have your Reviewed-by line? :)

Regards,
Hu

On Monday 24 November 2014 10:27:49 Hu Tao wrote:
> On Fri, Nov 21, 2014 at 11:35:11AM +0100, Pino Toscano wrote:
> > On Friday 21 November 2014 13:17:55 Hu Tao wrote:
> > > btrfs_subvolume_create creates only subvolumes.
> > > btrfs_subvolume_delete deletes subvolumes or snapshots.
> > > 
> > > Signed-off-by: Hu Tao <hutao@cn.fujitsu.com>
> > > ---
> > > 
> > >  generator/actions.ml | 8 ++++----
> > >  1 file changed, 4 insertions(+), 4 deletions(-)
> > > 
> > > diff --git a/generator/actions.ml b/generator/actions.ml
> > > index 89332f5..fe492e6 100644
> > > --- a/generator/actions.ml
> > > +++ b/generator/actions.ml
> > > @@ -10248,19 +10248,19 @@ of the snapshot, in the form
> > > C</path/to/dest/name>." };
["btrfs_subvolume_create"; "/test1"];
> > > 
> > >           ["btrfs_subvolume_delete";
"/test1"]]), []
> > >      
> > >      ];
> > > 
> > > -    shortdesc = "delete a btrfs snapshot";
> > > +    shortdesc = "delete a btrfs subvolume or
snapshot";
> > > 
> > >      longdesc = "\
> > > 
> > > -Delete the named btrfs subvolume." };
> > > +Delete the named btrfs subvolume or snapshot." };
> > > 
> > >    { defaults with
> > >    
> > >      name = "btrfs_subvolume_create";
> > >      style = RErr, [Pathname "dest"], [];
> > >      proc_nr = Some 324;
> > >      optional = Some "btrfs"; camel_name =
"BTRFSSubvolumeCreate";
> > > 
> > > -    shortdesc = "create a btrfs snapshot";
> > > +    shortdesc = "create a btrfs subvolume";
> > > 
> > >      longdesc = "\
> > >  
> > >  Create a btrfs subvolume.  The C<dest> argument is the
> > >  destination
> > > 
> > > -directory and the name of the snapshot, in the form
> > > C</path/to/dest/name>." }; +directory and the name of
the
> > > subvolume,
> > > in the form C</path/to/dest/name>." };
> > > 
> > >    { defaults with
> > >    
> > >      name = "btrfs_subvolume_list";
> > 
> > LGTM.
> 
> This means I can have your Reviewed-by line? :)
Ah, forgot to say that it was pushed already on Friday.

Thanks,
-- 
Pino Toscano