Pino Toscano
2014-Sep-10 11:13 UTC
[Libguestfs] [PATCH] resize: print FSes which cannot be expanded
Should ease a bit the discovery of a filesystem which cannot be
expanded.
---
Maybe it would be worth to be printed in any case, even if not being
verbose?
resize/resize.ml | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/resize/resize.ml b/resize/resize.ml
index 78ec81e..0485db0 100644
--- a/resize/resize.ml
+++ b/resize/resize.ml
@@ -558,7 +558,11 @@ read the man page virt-resize(1).
| ContentFS (("ntfs"), _) when !ntfs_available -> true
| ContentFS (("btrfs"), _) when !btrfs_available -> true
| ContentFS (("xfs"), _) when !xfs_available -> true
- | ContentFS (_, _) -> false
+ | ContentFS (fs, _) ->
+ if verbose then
+ eprintf "Unknown/unavailable method for expanding filesystem
%s\n"
+ fs;
+ false
| ContentExtendedPartition -> false
else
fun _ -> false
--
1.9.3
Richard W.M. Jones
2014-Sep-10 16:15 UTC
Re: [Libguestfs] [PATCH] resize: print FSes which cannot be expanded
On Wed, Sep 10, 2014 at 01:13:05PM +0200, Pino Toscano wrote:> Should ease a bit the discovery of a filesystem which cannot be > expanded. > --- > Maybe it would be worth to be printed in any case, even if not being > verbose? > > resize/resize.ml | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/resize/resize.ml b/resize/resize.ml > index 78ec81e..0485db0 100644 > --- a/resize/resize.ml > +++ b/resize/resize.ml > @@ -558,7 +558,11 @@ read the man page virt-resize(1). > | ContentFS (("ntfs"), _) when !ntfs_available -> true > | ContentFS (("btrfs"), _) when !btrfs_available -> true > | ContentFS (("xfs"), _) when !xfs_available -> true > - | ContentFS (_, _) -> false > + | ContentFS (fs, _) -> > + if verbose then > + eprintf "Unknown/unavailable method for expanding filesystem %s\n" > + fs; > + false > | ContentExtendedPartition -> false > else > fun _ -> false > --ACK. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://people.redhat.com/~rjones/virt-top