Pino Toscano
2014-Aug-13 14:46 UTC
[Libguestfs] [PATCH] build: manually drop flex-/bison-generated files from dist
It seems that Automake cannot handle properly the files generated by flex and bison, leaving them in the dist tarball. For now, add a dist-hook to manually prune them from distdir. --- builder/Makefile.am | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/builder/Makefile.am b/builder/Makefile.am index 0b4acd7..6a5cb01 100644 --- a/builder/Makefile.am +++ b/builder/Makefile.am @@ -317,3 +317,8 @@ index-parser-c.c index-scan.c index-validate.c: index-parse.h index-parse.h: index-parse.y $(MAKE) index-parse.h endif + +# Apparently there's no clean way with Automake to not have them +# in the distribution, so just remove them from the distdir. +dist-hook: + rm -f $(distdir)/index-parse.c $(distdir)/index-parse.h $(distdir)/index-scan.c -- 1.9.3
Richard W.M. Jones
2014-Aug-13 17:41 UTC
Re: [Libguestfs] [PATCH] build: manually drop flex-/bison-generated files from dist
On Wed, Aug 13, 2014 at 04:46:40PM +0200, Pino Toscano wrote:> It seems that Automake cannot handle properly the files generated by > flex and bison, leaving them in the dist tarball.I'm guessing it does this deliberately. However at the moment we require flex/bison (see configure.ac) and therefore ACK. Not sure there's any benefit to this though ... The tarball will be a fraction smaller and builds will take a fraction longer. Rich.> For now, add a dist-hook to manually prune them from distdir. > --- > builder/Makefile.am | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/builder/Makefile.am b/builder/Makefile.am > index 0b4acd7..6a5cb01 100644 > --- a/builder/Makefile.am > +++ b/builder/Makefile.am > @@ -317,3 +317,8 @@ index-parser-c.c index-scan.c index-validate.c: index-parse.h > index-parse.h: index-parse.y > $(MAKE) index-parse.h > endif > + > +# Apparently there's no clean way with Automake to not have them > +# in the distribution, so just remove them from the distdir. > +dist-hook: > + rm -f $(distdir)/index-parse.c $(distdir)/index-parse.h $(distdir)/index-scan.c > -- > 1.9.3 > > _______________________________________________ > Libguestfs mailing list > Libguestfs@redhat.com > https://www.redhat.com/mailman/listinfo/libguestfs-- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://people.redhat.com/~rjones/virt-top