Libguestfs - Aug 2014 - Re: How make check with test-harder.sh screw my box !!!!!

[Please keep replies on the list]

On Wed, Aug 13, 2014 at 02:16:29AM +0200, arnaud gaboury
wrote:
> See attached screenshot after supermin test with package "hivex".
This
> package is much more too heavy and breaks everything.
> And believe me, my box have quite strong muscles and compile everything,
fast.
> 
> Now with a few commits, results are at least here:
> 
> Testsuite summary for supermin 5.1.9
>
===========================================================================>
# TOTAL: 8
> # PASS:  8
> # SKIP:  0
> # XFAIL: 0
> # FAIL:  0
> # XPASS: 0
> # ERROR: 0
> 
> see https://github.com/gabx/supermin for my commits
It seems the main effect of the changes was to accidentally
disable network tests.

USE_NETWORK=1 command

and

USE_NETWORK=1
command

have quite different effects in bash.

Anyway an easier way to do that is to:

  ./configure --disable-network-tests

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-builder quickly builds VMs from scratch
http://libguestfs.org/virt-builder.1.html

On Wed, Aug 13, 2014 at 10:58 AM, Richard W.M. Jones <rjones@redhat.com>
wrote:
> [Please keep replies on the list]
>
The screenshot was not intended to be posted here. Nothing really interesting.
>>
>> Testsuite summary for supermin 5.1.9
>> ===========================>> # TOTAL: 8
>> # PASS:  8
That's for me the more important, as I know supermin is not broken.
>
> It seems the main effect of the changes was to accidentally
> disable network tests.
>
> USE_NETWORK=1 command
>
> and
>
> USE_NETWORK=1
> command
>
> have quite different effects in bash.
>
> Anyway an easier way to do that is to:
>
>   ./configure --disable-network-tests
>
Why? The idea to "make check" is good, so I do not see any interest in
running just parts of the tests.

On Wed, Aug 13, 2014 at 11:08:17AM +0200, arnaud gaboury
wrote:
> On Wed, Aug 13, 2014 at 10:58 AM, Richard W.M. Jones
<rjones@redhat.com> wrote:
> > It seems the main effect of the changes was to accidentally
> > disable network tests.
> >
> > USE_NETWORK=1 command
> >
> > and
> >
> > USE_NETWORK=1
> > command
> >
> > have quite different effects in bash.
> >
> > Anyway an easier way to do that is to:
> >
> >   ./configure --disable-network-tests
> >
> 
> Why? The idea to "make check" is good, so I do not see any
interest in
> running just parts of the tests.
You're disabling the network tests anyway because of the changes you
made to the tests.  The configure option is the official way to do that.
However as long as it works for you then fine.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
libguestfs lets you edit virtual machines.  Supports shell scripting,
bindings from many languages.  http://libguestfs.org