Pino Toscano
2014-Jul-07 09:43 UTC
[Libguestfs] [PATCH] inspect: ignore /etc/fstab with no entries (RHBZ#1113156).
Just like no /etc/fstab is not an error, having one with no entries
shouldn't be an issue either.
With systemd, this could be a valid setup, with mount points set its own
way.
---
src/inspect-fs-unix.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/src/inspect-fs-unix.c b/src/inspect-fs-unix.c
index 739a431..89236ab 100644
--- a/src/inspect-fs-unix.c
+++ b/src/inspect-fs-unix.c
@@ -960,11 +960,6 @@ check_fstab (guestfs_h *g, struct inspect_fs *fs)
if (entries == NULL)
return -1;
- if (entries[0] == NULL) {
- error (g, _("could not parse /etc/fstab or empty file"));
- return -1;
- }
-
for (entry = entries; *entry != NULL; entry++) {
CLEANUP_FREE char *spec = NULL;
CLEANUP_FREE char *mp = NULL;
--
1.9.3
Richard W.M. Jones
2014-Jul-07 11:53 UTC
Re: [Libguestfs] [PATCH] inspect: ignore /etc/fstab with no entries (RHBZ#1113156).
On Mon, Jul 07, 2014 at 11:43:01AM +0200, Pino Toscano wrote:> Just like no /etc/fstab is not an error, having one with no entries > shouldn't be an issue either. > > With systemd, this could be a valid setup, with mount points set its own > way.Yup, I think this is fine. ACK. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://people.redhat.com/~rjones/virt-top