Pino Toscano
2014-Jun-10 13:18 UTC
[Libguestfs] [PATCH] daemon: print parameters for vgchange in error messages
--- daemon/lvm-filter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/daemon/lvm-filter.c b/daemon/lvm-filter.c index ed10a48..6976bab 100644 --- a/daemon/lvm-filter.c +++ b/daemon/lvm-filter.c @@ -200,7 +200,7 @@ vgchange (const char *vgchange_flag) CLEANUP_FREE char *err = NULL; int r = command (NULL, &err, str_lvm, "vgchange", vgchange_flag, NULL); if (r == -1) { - reply_with_error ("vgchange: %s", err); + reply_with_error ("vgchange %s: %s", vgchange_flag, err); return -1; } -- 1.9.3
Richard W.M. Jones
2014-Jun-10 18:08 UTC
Re: [Libguestfs] [PATCH] daemon: print parameters for vgchange in error messages
On Tue, Jun 10, 2014 at 03:18:36PM +0200, Pino Toscano wrote:> --- > daemon/lvm-filter.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/daemon/lvm-filter.c b/daemon/lvm-filter.c > index ed10a48..6976bab 100644 > --- a/daemon/lvm-filter.c > +++ b/daemon/lvm-filter.c > @@ -200,7 +200,7 @@ vgchange (const char *vgchange_flag) > CLEANUP_FREE char *err = NULL; > int r = command (NULL, &err, str_lvm, "vgchange", vgchange_flag, NULL); > if (r == -1) { > - reply_with_error ("vgchange: %s", err); > + reply_with_error ("vgchange %s: %s", vgchange_flag, err); > return -1; > } >ACK. Improving error messages is basically something we can always do, so I think sensible error message improvements shouldn't need to be acked in future. Thanks, Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-builder quickly builds VMs from scratch http://libguestfs.org/virt-builder.1.html