Libguestfs - Mar 2014 - Re: [PATCH] Fix building on architectures where ocamlopt is not available

* Richard W.M. Jones:
> (1) Removing .NOTPARALLEL.  This fails, as expected.
>
> (2) mlguestfs.cmxa: mlguestfs.cma  -- fails
>
> (3) mlguestfs.cmxa: | mlguestfs.cma  -- fails after a longer time
I find it strange that (2) and (3) fail.
> (4) The attached patch which is derived from dce94f -- this ran
> without failing for 120 iterations (and still going).
The patch looks good to me.

-Hilko

On Sun, Mar 23, 2014 at 07:22:57PM +0100, Hilko Bengen
wrote:
> * Richard W.M. Jones:
> 
> > (1) Removing .NOTPARALLEL.  This fails, as expected.
> >
> > (2) mlguestfs.cmxa: mlguestfs.cma  -- fails
> >
> > (3) mlguestfs.cmxa: | mlguestfs.cma  -- fails after a longer time
> 
> I find it strange that (2) and (3) fail.
No I don't either.  Just to make sure, I reran test (3) again.  See
attached patch.  The failure is:

  ocamlmklib -o mlguestfs \
    libguestfsocaml_a-guestfs-c.o libguestfsocaml_a-guestfs-c-actions.o
libguestfsocaml_a-utils.o guestfs.cmx \
    -L../src/.libs -lguestfs
  File "_none_", line 1:
  Error: Error on dynamically loaded library: ./dllmlguestfs.so:
./dllmlguestfs.so: file too short
  make: *** [t/guestfs_420_log_messages.bc] Error 2
  make: *** Waiting for unfinished jobs....
  Warning: Element Unix.error not found
  make: Leaving directory `/home/rjones/d/libguestfs/ocaml'

It does run for quite a few iterations before it hits this failure, so
obviously the failure window is narrow.
> > (4) The attached patch which is derived from dce94f -- this ran
> > without failing for 120 iterations (and still going).
> 
> The patch looks good to me.
Thanks, I think I'll push my version unless anyone can see what's
wrong with the simpler version.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
libguestfs lets you edit virtual machines.  Supports shell scripting,
bindings from many languages.  http://libguestfs.org

On Sun, Mar 23, 2014 at 06:31:40PM +0000, Richard W.M. Jones
wrote:
> On Sun, Mar 23, 2014 at 07:22:57PM +0100, Hilko Bengen wrote:
> > * Richard W.M. Jones:
> > 
> > > (1) Removing .NOTPARALLEL.  This fails, as expected.
> > >
> > > (2) mlguestfs.cmxa: mlguestfs.cma  -- fails
> > >
> > > (3) mlguestfs.cmxa: | mlguestfs.cma  -- fails after a longer time
> > 
> > I find it strange that (2) and (3) fail.
> 
> No I don't either.
I meant to say: I do find it strange too.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
virt-p2v converts physical machines to virtual machines.  Boot with a
live CD or over the network (PXE) and turn machines into KVM guests.
http://libguestfs.org/virt-v2v