Libguestfs - Mar 2014 - Re: [PATCH pkg-libvirt/libguestfs] Remove update-guestfs-appliance

[First attempt to send this using git send-email didn't work because
of SMTP routing problems]

Hilko,

This is my experimental patch to remove update-guestfs-appliance from
Debian.  With this patch, libguestfs builds with a supermin [version 5]
appliance in /usr/lib/guestfs/supermin.d:

$ ll -h /usr/lib/guestfs/supermin.d/
total 884K
-rw-r--r-- 1 root root  94K Mar 15 12:18 base.tar.gz
-rw-r--r-- 1 root root 767K Mar 15 12:18 daemon.tar.gz
-rw-r--r-- 1 root root  263 Mar 15 12:18 excludefiles
-rw-r--r-- 1 root root   42 Mar 15 12:18 hostfiles
-rw-r--r-- 1 root root 2.1K Mar 15 12:18 init.tar.gz
-rw-r--r-- 1 root root  462 Mar 15 12:18 packages
-rw-r--r-- 1 root root  543 Mar 15 12:18 udev-rules.tar.gz

libguestfs-test-tool works after installation.  I tried a few other
things, but it has not been comprehensively tested.

Note that if you previously had libguestfs installed, and you ran
update-guestfs-appliance, it will have created a cpio file called
'base.img' in /usr/lib/guestfs/supermin.d/.  This file breaks supermin
unless it is removed.  I attempted to modify postinst to remove it,
but that didn't work for some reason.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
libguestfs lets you edit virtual machines.  Supports shell scripting,
bindings from many languages.  http://libguestfs.org

* Richard W.M. Jones:
> [First attempt to send this using git send-email didn't work because
> of SMTP routing problems]
I did actually get the first mail.
> This is my experimental patch to remove update-guestfs-appliance from
> Debian.  With this patch, libguestfs builds with a supermin [version 5]
> appliance in /usr/lib/guestfs/supermin.d:
Thank you. Since libguestfs0 is a multiarch package, I have moved the
appliance back to /usr/lib/<multiarch>/guestfs by dropping
debian/patches/0001-Fix-guestfs-supermin-appliance-path.patch.

Once this builds in my chroot, I'll upload to experimental.

Cheers,
-Hilko

On Sat, Mar 15, 2014 at 08:58:17PM +0100, Hilko Bengen
wrote:
> Thank you. Since libguestfs0 is a multiarch package, I have moved the
> appliance back to /usr/lib/<multiarch>/guestfs by dropping
> debian/patches/0001-Fix-guestfs-supermin-appliance-path.patch.
Yes, I believe that's correct.  Also on Fedora we put the appliance
into an arch-dependent package because it is [or least could
potentially be] arch-dependent.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
virt-df lists disk usage of guests without needing to install any
software inside the virtual machine.  Supports Linux and Windows.
http://people.redhat.com/~rjones/virt-df/

I've just realized a couple of things:

(1) Reason why postinst removal of base.img doesn't work: Because it
was the libguestfs-tools postinst (not libguestfs0).  In any case this
is not so important, since the new supermin appliance is located in a
different directory now because of multiarch.

(2) The attached patch gets rid of some appliance installation rules
that aren't really needed any longer.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Fedora Windows cross-compiler. Compile Windows programs, test, and
build Windows installers. Over 100 libraries supported.
http://fedoraproject.org/wiki/MinGW