Olaf Hering
2014-Mar-11 09:51 UTC
Re: [Libguestfs] [PATCH] Fix building on architectures where ocamlopt is not available
On Fri, Feb 28, Richard W.M. Jones wrote:> I can't test if it will specifically break this because I don't have > access to any machines that don't have ocamlopt, but it's something to > watch out for. > > In any case, I have pushed this since it works fine for me.Any chance this can be backported to 1.24? Olaf
Richard W.M. Jones
2014-Mar-11 10:59 UTC
Re: [Libguestfs] [PATCH] Fix building on architectures where ocamlopt is not available
On Tue, Mar 11, 2014 at 10:51:50AM +0100, Olaf Hering wrote:> On Fri, Feb 28, Richard W.M. Jones wrote: > > > I can't test if it will specifically break this because I don't have > > access to any machines that don't have ocamlopt, but it's something to > > watch out for. > > > > In any case, I have pushed this since it works fine for me. > > Any chance this can be backported to 1.24?Actually I looked at the patch when I was doing the 1.24.8 release but IIRC it was not a clean cherry pick. How about carrying it as a downstream patch (just for 1.24)? Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-df lists disk usage of guests without needing to install any software inside the virtual machine. Supports Linux and Windows. http://people.redhat.com/~rjones/virt-df/
Olaf Hering
2014-Mar-11 11:07 UTC
Re: [Libguestfs] [PATCH] Fix building on architectures where ocamlopt is not available
On Tue, Mar 11, Richard W.M. Jones wrote:> Actually I looked at the patch when I was doing the 1.24.8 release but > IIRC it was not a clean cherry pick.Thats why I sent out my backport to 1.24.x, too.> How about carrying it as a downstream patch (just for 1.24)?It requires changes to Makefile.in as well because, depending on the distversion, automake is too old at least in SLES11. Olaf