Libguestfs - Feb 2014 - [PATCH] builder: add libguestfs.gpg to EXTRA_DIST

On Tue, Feb 25, 2014 at 05:29:10PM +0100, Pino Toscano
wrote:
> Introduce and use simple .conf files to configure the sources of indexes
> for virt-builder. The location of these files is in XDG_CONFIG_DIRS /
> XDG_CONFIG_HOME, so it can be easily overridden.
> 
> There are three .conf(.in) files shipped with this commit:
> - "test-index.conf.in" (in "test-config"), which points
to the
>   "test-index" index (used in tests only); the tests are adapted
to
>   point to the hierarchy containing this .conf
> - "libguestfs.conf.in" (in "test-website"), which
points to the local
>   "index.asc" (i.e. the offline copy of the libguestfs.org
index);
>   run(.in) will point to the hierarchy providing this .conf
> - "libguestfs.conf.in" (directly among the other sources), which
points
>   to the online "index.asc" and it is installed in sysconfdir,
along
>   with the key of this repository
> 
> The tests are adapted, other than to the different way to pick sources,
> to the different output of --list, as "test-index" is not signed.
This is missing changes to EXTRA_DIST.

You can automatically find out what additions to EXTRA_DIST are needed
by doing:

  make && make dist && make maintainer-check-extra-dist

Note that some files are known to be missing from EXTRA_DIST already --
that is an existing bug.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
virt-df lists disk usage of guests without needing to install any
software inside the virtual machine.  Supports Linux and Windows.
http://people.redhat.com/~rjones/virt-df/

On Thursday 27 February 2014 10:10:39 Richard W.M. Jones
wrote:
> On Tue, Feb 25, 2014 at 05:29:10PM +0100, Pino Toscano wrote:
> > Introduce and use simple .conf files to configure the sources of
> > indexes for virt-builder. The location of these files is in
> > XDG_CONFIG_DIRS / XDG_CONFIG_HOME, so it can be easily overridden.
> > 
> > There are three .conf(.in) files shipped with this commit:
> > - "test-index.conf.in" (in "test-config"), which
points to the
> > 
> >   "test-index" index (used in tests only); the tests are
adapted to
> >   point to the hierarchy containing this .conf
> > 
> > - "libguestfs.conf.in" (in "test-website"), which
points to the
> > local
> > 
> >   "index.asc" (i.e. the offline copy of the libguestfs.org
index);
> >   run(.in) will point to the hierarchy providing this .conf
> > 
> > - "libguestfs.conf.in" (directly among the other sources),
which
> > points> 
> >   to the online "index.asc" and it is installed in
sysconfdir, along
> >   with the key of this repository
> > 
> > The tests are adapted, other than to the different way to pick
> > sources, to the different output of --list, as "test-index"
is not
> > signed.
> This is missing changes to EXTRA_DIST.
> 
> You can automatically find out what additions to EXTRA_DIST are needed
> by doing:
> 
>   make && make dist && make maintainer-check-extra-dist
> 
> Note that some files are known to be missing from EXTRA_DIST already
> -- that is an existing bug.
More than this commit, it was the patch 4 of this series that did. Patch 
coming in a minute.

Thanks for the notice,
-- 
Pino Toscano

It needs to be in EXTRA_DIST, otherwise it is not put in the dist.
---
 builder/Makefile.am | 1 +
 1 file changed, 1 insertion(+)

diff --git a/builder/Makefile.am b/builder/Makefile.am
index f0cb1dd..2dc9d23 100644
--- a/builder/Makefile.am
+++ b/builder/Makefile.am
@@ -27,6 +27,7 @@ AM_CFLAGS = \
 
 EXTRA_DIST = \
 	$(SOURCES) \
+	libguestfs.gpg \
 	virt-builder.pod \
 	virt-index-validate.pod \
 	test-virt-builder.sh \
-- 
1.8.3.1