Richard W.M. Jones
2014-Feb-17 09:17 UTC
[Libguestfs] [PATCH] builder: Really add extra dependencies on index-parse.h that automake doesn't generate correctly.
See: https://www.redhat.com/archives/libguestfs/2014-February/msg00148.html This updates commit e2cc8b6465a400024fe2f0fcce0d0ff5f7e7719c. Also use $(OBJECT) instead of hard-coding the .o extension. --- builder/Makefile.am | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/builder/Makefile.am b/builder/Makefile.am index 3087ac4..39e6588 100644 --- a/builder/Makefile.am +++ b/builder/Makefile.am @@ -248,7 +248,7 @@ CLEANFILES += \ # Fix dependencies which automake doesn't generate correctly. if HAVE_OCAML -index-parser-c.o: index-parse.h index-struct.h -index-scan.o: index-parse.h +index-parser-c.$(OBJECT): index-parse.h index-struct.h +index-scan.$(OBJECT): index-parse.h endif -index-validate.o: index-parse.h +virt_index_validate-index-validate.$(OBJECT): index-parse.h -- 1.8.4.2
Richard W.M. Jones
2014-Feb-17 09:43 UTC
Re: [Libguestfs] [PATCH] builder: Really add extra dependencies on index-parse.h that automake doesn't generate correctly.
On Mon, Feb 17, 2014 at 09:17:02AM +0000, Richard W.M. Jones wrote:> See: > https://www.redhat.com/archives/libguestfs/2014-February/msg00148.html > > This updates commit e2cc8b6465a400024fe2f0fcce0d0ff5f7e7719c.This commit is wrong. Coming up with a better commit ... Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into KVM guests. http://libguestfs.org/virt-v2v