Libguestfs - Oct 2013 - augeas changes in stable branches

commit f59b87f7f18d9df89ff9940a317ff1fb452cbd28 breaks compile with older
augeas (0.7.4). AFAIK there is no requirement for augeas 1.0 until 1.24.

 augeas.c: In function 'do_aug_init':
 augeas.c:102:38: error: 'AUG_NO_ERR_CLOSE' undeclared (first use in
this function)


Olaf

On Fri, Oct 18, 2013 at 11:15:54AM +0200, Olaf Hering
wrote:
> 
> commit f59b87f7f18d9df89ff9940a317ff1fb452cbd28 breaks compile with older
> augeas (0.7.4). AFAIK there is no requirement for augeas 1.0 until 1.24.
> 
>  augeas.c: In function 'do_aug_init':
>  augeas.c:102:38: error: 'AUG_NO_ERR_CLOSE' undeclared (first use
in this function)
That's a mistake on the stable-1.22 branch.  Does simply reverting
that patch fix the problem?  If so I will push a revert commit.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming blog: http://rwmj.wordpress.com
Fedora now supports 80 OCaml packages (the OPEN alternative to F#)

On Fri, Oct 18, 2013 at 02:37:48PM +0100, Richard W.M. Jones
wrote:
> On Fri, Oct 18, 2013 at 11:15:54AM +0200, Olaf Hering wrote:
> > 
> > commit f59b87f7f18d9df89ff9940a317ff1fb452cbd28 breaks compile with
older
> > augeas (0.7.4). AFAIK there is no requirement for augeas 1.0 until
1.24.
> > 
> >  augeas.c: In function 'do_aug_init':
> >  augeas.c:102:38: error: 'AUG_NO_ERR_CLOSE' undeclared (first
use in this function)
> 
> That's a mistake on the stable-1.22 branch.  Does simply reverting
> that patch fix the problem?  If so I will push a revert commit.
That's not going to be sufficient.

I think we will have to revert:

272cc56876b9a3449da2fdfff546c598497d846d
f59b87f7f18d9df89ff9940a317ff1fb452cbd28

Does reverting both of those fix it?

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
libguestfs lets you edit virtual machines.  Supports shell scripting,
bindings from many languages.  http://libguestfs.org

On Fri, Oct 18, Richard W.M. Jones wrote:
> On Fri, Oct 18, 2013 at 11:15:54AM +0200, Olaf Hering wrote:
> > 
> > commit f59b87f7f18d9df89ff9940a317ff1fb452cbd28 breaks compile with
older
> > augeas (0.7.4). AFAIK there is no requirement for augeas 1.0 until
1.24.
> > 
> >  augeas.c: In function 'do_aug_init':
> >  augeas.c:102:38: error: 'AUG_NO_ERR_CLOSE' undeclared (first
use in this function)
> 
> That's a mistake on the stable-1.22 branch.  Does simply reverting
> that patch fix the problem?  If so I will push a revert commit.
AUG_NO_ERR_CLOSE is not a define but an enum. So
f59b87f7f18d9df89ff9940a317ff1fb452cbd28 is correct by itself, but
3d132f29204e8c5c77f08841b5288dfe3013f4f0 will cause the error by using
an undeclared value.

I suggest to revert both commits.

Olaf