Libguestfs - Sep 2013 - [PATCH V2] sysprep: remove firewall rules

If we do not want to keep the original firewall rules, enable
this operation to remove these rules automatically.

Signed-off-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>
---
 sysprep/Makefile.am                         |  1 +
 sysprep/sysprep_operation_firewall_rules.ml | 54 +++++++++++++++++++++++++++++
 2 files changed, 55 insertions(+)
 create mode 100644 sysprep/sysprep_operation_firewall_rules.ml

diff --git a/sysprep/Makefile.am b/sysprep/Makefile.am
index ec6c2bc..fcd17fc 100644
--- a/sysprep/Makefile.am
+++ b/sysprep/Makefile.am
@@ -40,6 +40,7 @@ operations = \
 	dhcp_server_state \
 	dovecot_data \
 	flag_reconfiguration \
+	firewall_rules \
 	firstboot \
 	fs_uuids \
 	hostname \
diff --git a/sysprep/sysprep_operation_firewall_rules.ml
b/sysprep/sysprep_operation_firewall_rules.ml
new file mode 100644
index 0000000..598b2e1
--- /dev/null
+++ b/sysprep/sysprep_operation_firewall_rules.ml
@@ -0,0 +1,54 @@
+(* virt-sysprep
+ * Copyright (C) 2013 Fujitsu Limited.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License along
+ * with this program; if not, write to the Free Software Foundation, Inc.,
+ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
+ *)
+
+open Sysprep_operation
+open Common_gettext.Gettext
+
+module G = Guestfs
+
+let firewall_rules_perform g root +  let typ = g#inspect_get_type root in
+  if typ <> "windows" then (
+    let paths = [ "/etc/sysconfig/iptables";
+                  "/etc/firewalld/services/*";
+                  "/etc/firewalld/zones/*"; ] in
+    List.iter (
+      fun path ->
+        let files = g#glob_expand path in
+        Array.iter (
+          fun file ->
+            try g#rm file with G.Error _ -> ()
+        ) files;
+    ) paths;
+
+    []
+  )
+  else []
+
+let op = {
+  defaults with
+    name = "firewall-rules";
+    enabled_by_default = false;
+    heading = s_"Remove the firewall rules";
+    pod_description = Some (s_"\
+If you do not want to keep the custom firewall rules, enable this operation
+to remove it automatically.");
+    perform_on_filesystems = Some firewall_rules_perform;
+}
+
+let () = register_operation op
-- 
1.8.4.27.g0a41de8

On Thu, Sep 05, 2013 at 07:13:22PM +0800, Wanlong Gao
wrote:
> If we do not want to keep the original firewall rules, enable
> this operation to remove these rules automatically.
Thanks, I will push this shortly.

I made a minor change to the documentation.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Fedora Windows cross-compiler. Compile Windows programs, test, and
build Windows installers. Over 100 libraries supported.
http://fedoraproject.org/wiki/MinGW