Libguestfs - Feb 2012 - [PATCH] Eliminate duplicate entries from package list

"apt-cache depends --recurse -i ..." on Ubuntu 12.04 (apt
0.8.16~exp12ubuntu3) outputs duplicate entries which broke the code
that checks whether all package files have been successfully
downloaded. I am not sure if this is a bug in apt.
---
 src/febootstrap_debian.ml |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/febootstrap_debian.ml b/src/febootstrap_debian.ml
index 8d0f75f..d1ee8ab 100644
--- a/src/febootstrap_debian.ml
+++ b/src/febootstrap_debian.ml
@@ -53,7 +53,7 @@ let rec debian_resolve_dependencies_and_download names      if
Config.apt_cache_depends_recurse_broken then
       workaround_broken_apt_cache_depends_recurse (sort_uniq pkgs)
     else
-      pkgs in
+      sort_uniq pkgs in
 
   (* Exclude packages matching [--exclude] regexps on the command line. *)
   let pkgs -- 
1.7.9

On Sat, Feb 11, 2012 at 11:27:33PM +0100, Hilko Bengen
wrote:
> "apt-cache depends --recurse -i ..." on Ubuntu 12.04 (apt
> 0.8.16~exp12ubuntu3) outputs duplicate entries which broke the code
> that checks whether all package files have been successfully
> downloaded. I am not sure if this is a bug in apt.
> ---
>  src/febootstrap_debian.ml |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/src/febootstrap_debian.ml b/src/febootstrap_debian.ml
> index 8d0f75f..d1ee8ab 100644
> --- a/src/febootstrap_debian.ml
> +++ b/src/febootstrap_debian.ml
> @@ -53,7 +53,7 @@ let rec debian_resolve_dependencies_and_download names
>      if Config.apt_cache_depends_recurse_broken then
>        workaround_broken_apt_cache_depends_recurse (sort_uniq pkgs)
>      else
> -      pkgs in
> +      sort_uniq pkgs in
>  
>    (* Exclude packages matching [--exclude] regexps on the command line. *)
>    let pkgs > -- 
> 1.7.9
ACK, in that I cannot see any problem that this could cause.

I'm currently downloading Ubuntu 12.04 alpha so I can look at the
other problems reported over the weekend.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
virt-p2v converts physical machines to virtual machines.  Boot with a
live CD or over the network (PXE) and turn machines into Xen guests.
http://et.redhat.com/~rjones/virt-p2v