I've sent a github pull request containing this patch here: https://github.com/libguestfs/libguestfs/pull/1 I'm interested to know if this interface could be useful to the project. We should be wary, though, of tying useful development history in the form of review discussion into github's proprietary system. Your thoughts are appreciated. Incidentally, I'm also looking for ACKs on this patch :) Matt
Remove generated file from source control, and don't barf when it doesn't exist while bootstrapping. --- generator/.depend | 158 ------------------------------------------------- generator/Makefile.am | 2 +- 2 files changed, 1 insertions(+), 159 deletions(-) delete mode 100644 generator/.depend diff --git a/generator/.depend b/generator/.depend deleted file mode 100644 index acbce64..0000000 --- a/generator/.depend +++ /dev/null @@ -1,158 +0,0 @@ -generator_types.cmo: -generator_types.cmx: -generator_utils.cmi: generator_types.cmo -generator_utils.cmo: generator_types.cmo generator_utils.cmi -generator_utils.cmx: generator_types.cmx generator_utils.cmi -generator_actions.cmi: generator_types.cmo -generator_actions.cmo: generator_utils.cmi generator_types.cmo \ - generator_actions.cmi -generator_actions.cmx: generator_utils.cmx generator_types.cmx \ - generator_actions.cmi -generator_structs.cmi: generator_types.cmo -generator_structs.cmo: generator_utils.cmi generator_types.cmo \ - generator_structs.cmi -generator_structs.cmx: generator_utils.cmx generator_types.cmx \ - generator_structs.cmi -generator_api_versions.cmi: -generator_api_versions.cmo: generator_utils.cmi generator_api_versions.cmi -generator_api_versions.cmx: generator_utils.cmx generator_api_versions.cmi -generator_optgroups.cmo: generator_types.cmo generator_actions.cmi -generator_optgroups.cmx: generator_types.cmx generator_actions.cmx -generator_prepopts.cmi: -generator_prepopts.cmo: generator_prepopts.cmi -generator_prepopts.cmx: generator_prepopts.cmi -generator_events.cmo: generator_utils.cmi -generator_events.cmx: generator_utils.cmx -generator_pr.cmi: -generator_pr.cmo: generator_utils.cmi generator_pr.cmi -generator_pr.cmx: generator_utils.cmx generator_pr.cmi -generator_docstrings.cmo: generator_utils.cmi generator_types.cmo \ - generator_pr.cmi -generator_docstrings.cmx: generator_utils.cmx generator_types.cmx \ - generator_pr.cmx -generator_checks.cmo: generator_utils.cmi generator_types.cmo \ - generator_actions.cmi -generator_checks.cmx: generator_utils.cmx generator_types.cmx \ - generator_actions.cmx -generator_c.cmo: generator_utils.cmi generator_types.cmo \ - generator_structs.cmi generator_pr.cmi generator_optgroups.cmo \ - generator_events.cmo generator_docstrings.cmo generator_api_versions.cmi \ - generator_actions.cmi -generator_c.cmx: generator_utils.cmx generator_types.cmx \ - generator_structs.cmx generator_pr.cmx generator_optgroups.cmx \ - generator_events.cmx generator_docstrings.cmx generator_api_versions.cmx \ - generator_actions.cmx -generator_xdr.cmo: generator_utils.cmi generator_types.cmo \ - generator_structs.cmi generator_pr.cmi generator_optgroups.cmo \ - generator_docstrings.cmo generator_actions.cmi -generator_xdr.cmx: generator_utils.cmx generator_types.cmx \ - generator_structs.cmx generator_pr.cmx generator_optgroups.cmx \ - generator_docstrings.cmx generator_actions.cmx -generator_daemon.cmo: generator_utils.cmi generator_types.cmo \ - generator_structs.cmi generator_pr.cmi generator_optgroups.cmo \ - generator_docstrings.cmo generator_c.cmo generator_actions.cmi -generator_daemon.cmx: generator_utils.cmx generator_types.cmx \ - generator_structs.cmx generator_pr.cmx generator_optgroups.cmx \ - generator_docstrings.cmx generator_c.cmx generator_actions.cmx -generator_tests_c_api.cmo: generator_utils.cmi generator_types.cmo \ - generator_structs.cmi generator_pr.cmi generator_optgroups.cmo \ - generator_docstrings.cmo generator_actions.cmi -generator_tests_c_api.cmx: generator_utils.cmx generator_types.cmx \ - generator_structs.cmx generator_pr.cmx generator_optgroups.cmx \ - generator_docstrings.cmx generator_actions.cmx -generator_fish.cmo: generator_utils.cmi generator_types.cmo \ - generator_structs.cmi generator_prepopts.cmi generator_pr.cmi \ - generator_optgroups.cmo generator_events.cmo generator_docstrings.cmo \ - generator_c.cmo generator_actions.cmi -generator_fish.cmx: generator_utils.cmx generator_types.cmx \ - generator_structs.cmx generator_prepopts.cmx generator_pr.cmx \ - generator_optgroups.cmx generator_events.cmx generator_docstrings.cmx \ - generator_c.cmx generator_actions.cmx -generator_ocaml.cmo: generator_utils.cmi generator_types.cmo \ - generator_structs.cmi generator_pr.cmi generator_optgroups.cmo \ - generator_events.cmo generator_docstrings.cmo generator_c.cmo \ - generator_actions.cmi -generator_ocaml.cmx: generator_utils.cmx generator_types.cmx \ - generator_structs.cmx generator_pr.cmx generator_optgroups.cmx \ - generator_events.cmx generator_docstrings.cmx generator_c.cmx \ - generator_actions.cmx -generator_perl.cmo: generator_utils.cmi generator_types.cmo \ - generator_structs.cmi generator_pr.cmi generator_optgroups.cmo \ - generator_events.cmo generator_docstrings.cmo generator_c.cmo \ - generator_actions.cmi -generator_perl.cmx: generator_utils.cmx generator_types.cmx \ - generator_structs.cmx generator_pr.cmx generator_optgroups.cmx \ - generator_events.cmx generator_docstrings.cmx generator_c.cmx \ - generator_actions.cmx -generator_python.cmo: generator_utils.cmi generator_types.cmo \ - generator_structs.cmi generator_pr.cmi generator_optgroups.cmo \ - generator_events.cmo generator_docstrings.cmo generator_c.cmo \ - generator_actions.cmi -generator_python.cmx: generator_utils.cmx generator_types.cmx \ - generator_structs.cmx generator_pr.cmx generator_optgroups.cmx \ - generator_events.cmx generator_docstrings.cmx generator_c.cmx \ - generator_actions.cmx -generator_ruby.cmo: generator_utils.cmi generator_types.cmo \ - generator_structs.cmi generator_pr.cmi generator_optgroups.cmo \ - generator_events.cmo generator_docstrings.cmo generator_c.cmo \ - generator_actions.cmi -generator_ruby.cmx: generator_utils.cmx generator_types.cmx \ - generator_structs.cmx generator_pr.cmx generator_optgroups.cmx \ - generator_events.cmx generator_docstrings.cmx generator_c.cmx \ - generator_actions.cmx -generator_java.cmo: generator_utils.cmi generator_types.cmo \ - generator_structs.cmi generator_pr.cmi generator_optgroups.cmo \ - generator_docstrings.cmo generator_c.cmo generator_actions.cmi -generator_java.cmx: generator_utils.cmx generator_types.cmx \ - generator_structs.cmx generator_pr.cmx generator_optgroups.cmx \ - generator_docstrings.cmx generator_c.cmx generator_actions.cmx -generator_haskell.cmo: generator_utils.cmi generator_types.cmo \ - generator_structs.cmi generator_pr.cmi generator_optgroups.cmo \ - generator_docstrings.cmo generator_actions.cmi -generator_haskell.cmx: generator_utils.cmx generator_types.cmx \ - generator_structs.cmx generator_pr.cmx generator_optgroups.cmx \ - generator_docstrings.cmx generator_actions.cmx -generator_csharp.cmo: generator_utils.cmi generator_types.cmo \ - generator_structs.cmi generator_pr.cmi generator_optgroups.cmo \ - generator_docstrings.cmo generator_actions.cmi -generator_csharp.cmx: generator_utils.cmx generator_types.cmx \ - generator_structs.cmx generator_pr.cmx generator_optgroups.cmx \ - generator_docstrings.cmx generator_actions.cmx -generator_php.cmo: generator_utils.cmi generator_types.cmo \ - generator_structs.cmi generator_pr.cmi generator_optgroups.cmo \ - generator_docstrings.cmo generator_c.cmo generator_actions.cmi -generator_php.cmx: generator_utils.cmx generator_types.cmx \ - generator_structs.cmx generator_pr.cmx generator_optgroups.cmx \ - generator_docstrings.cmx generator_c.cmx generator_actions.cmx -generator_erlang.cmo: generator_utils.cmi generator_types.cmo \ - generator_structs.cmi generator_pr.cmi generator_optgroups.cmo \ - generator_events.cmo generator_docstrings.cmo generator_c.cmo \ - generator_actions.cmi -generator_erlang.cmx: generator_utils.cmx generator_types.cmx \ - generator_structs.cmx generator_pr.cmx generator_optgroups.cmx \ - generator_events.cmx generator_docstrings.cmx generator_c.cmx \ - generator_actions.cmx -generator_bindtests.cmo: generator_utils.cmi generator_types.cmo \ - generator_structs.cmi generator_pr.cmi generator_optgroups.cmo \ - generator_docstrings.cmo generator_c.cmo generator_actions.cmi -generator_bindtests.cmx: generator_utils.cmx generator_types.cmx \ - generator_structs.cmx generator_pr.cmx generator_optgroups.cmx \ - generator_docstrings.cmx generator_c.cmx generator_actions.cmx -generator_errnostring.cmo: generator_utils.cmi generator_types.cmo \ - generator_pr.cmi generator_docstrings.cmo -generator_errnostring.cmx: generator_utils.cmx generator_types.cmx \ - generator_pr.cmx generator_docstrings.cmx -generator_main.cmo: generator_xdr.cmo generator_tests_c_api.cmo \ - generator_structs.cmi generator_ruby.cmo generator_python.cmo \ - generator_pr.cmi generator_php.cmo generator_perl.cmo generator_ocaml.cmo \ - generator_java.cmo generator_haskell.cmo generator_fish.cmo \ - generator_errnostring.cmo generator_erlang.cmo generator_daemon.cmo \ - generator_csharp.cmo generator_c.cmo generator_bindtests.cmo \ - generator_api_versions.cmi -generator_main.cmx: generator_xdr.cmx generator_tests_c_api.cmx \ - generator_structs.cmx generator_ruby.cmx generator_python.cmx \ - generator_pr.cmx generator_php.cmx generator_perl.cmx generator_ocaml.cmx \ - generator_java.cmx generator_haskell.cmx generator_fish.cmx \ - generator_errnostring.cmx generator_erlang.cmx generator_daemon.cmx \ - generator_csharp.cmx generator_c.cmx generator_bindtests.cmx \ - generator_api_versions.cmx diff --git a/generator/Makefile.am b/generator/Makefile.am index dfa5893..b01cf35 100644 --- a/generator/Makefile.am +++ b/generator/Makefile.am @@ -79,7 +79,7 @@ depend: .depend $(OCAMLDEP) $^ | sed 's/ *$$//' > $@-t mv $@-t $@ -include .depend +-include .depend else -- 1.7.7.5
On Wed, Jan 11, 2012 at 11:35:50AM +0000, Matthew Booth wrote:> I've sent a github pull request containing this patch here: > > https://github.com/libguestfs/libguestfs/pull/1 > > I'm interested to know if this interface could be useful to the project. We > should be wary, though, of tying useful development history in the form of > review discussion into github's proprietary system. Your thoughts are > appreciated.I don't think we should be using a closed source, web-based tool to do reviews, and we should stick with the mailing list for now. OTOH pull requests themselves are a useful way for committers to test patches, and also to commit patches that come from people who don't have commit rights. Thus adding a git URL (be it github or another mirror you want to use) to patches that are also posted to the mailing list can be useful. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://et.redhat.com/~rjones/virt-top
Possibly Parallel Threads
- [PATCH 1/2] generator: Rename java_structs to camel_structs to better reflect their purpose
- [PATCH 1/3] gobject: NFC generated code formatting fix
- [PATCH 0/7] Add tar compress, numericowner, excludes flags.
- [PATCH for discussion only] New event API (RHBZ#664558).
- [PATCH 01/10] Revert "Revert "generator: Add CamelName flag""