Libguestfs - Nov 2011 - [PATCH 1/2] Create an MD variant of the dummy Fedora image

This change involves rewriting make-fedora-img.sh in perl. This allows the
flexibility to write mdadm.conf containing whichever uuids where randomly
generated when the md devices were created.
---
 .gitignore                          |    2 +
 images/Makefile.am                  |   18 +++-
 images/guest-aux/make-fedora-img.pl |  194 +++++++++++++++++++++++++++++++++++
 images/guest-aux/make-fedora-img.sh |  110 --------------------
 4 files changed, 210 insertions(+), 114 deletions(-)
 create mode 100755 images/guest-aux/make-fedora-img.pl
 delete mode 100755 images/guest-aux/make-fedora-img.sh

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Create-an-MD-variant-of-the-dummy-Fedora-image.patch
Type: text/x-patch
Size: 10512 bytes
Desc: not available
URL:
<http://listman.redhat.com/archives/libguestfs/attachments/20111122/7eab649f/attachment.bin>

---
 Makefile.am |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-build-nothing-under-images-should-be-translated.patch
Type: text/x-patch
Size: 312 bytes
Desc: not available
URL:
<http://listman.redhat.com/archives/libguestfs/attachments/20111122/cb536a57/attachment.bin>

General comment:

Can you use git send-email to send the patches?  I think I had
problems applying those patches before, but now I'm finding it
problematic to apply patches that are attachments.
> +# Make a (dummy) Fedora image using md devices
> +fedora-md1.img fedora-md2.img: guest-aux/make-fedora-img.pl \
I believe this will run the Perl script twice on updates.  You need to
use a stamp file, eg:

  fedora-md1.img fedora-md2.img: stamp-fedora-md

  stamp-fedora-md: guest-aux/make-fedora-img.pl  [etc]
    [rules]

The tests pass for me, so ACK.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming blog: http://rwmj.wordpress.com
Fedora now supports 80 OCaml packages (the OPEN alternative to F#)
http://cocan.org/getting_started_with_ocaml_on_red_hat_and_fedora

On 11/22/2011 11:29 PM, Matthew Booth wrote:
> 
> This change involves rewriting make-fedora-img.sh in perl. This allows the
> flexibility to write mdadm.conf containing whichever uuids where randomly
> generated when the md devices were created.

Reviewed-by: Wanlong Gao <gaowanlong at cn.fujitsu.com>
> ---
>  .gitignore                          |    2 +
>  images/Makefile.am                  |   18 +++-
>  images/guest-aux/make-fedora-img.pl |  194
+++++++++++++++++++++++++++++++++++
>  images/guest-aux/make-fedora-img.sh |  110 --------------------
>  4 files changed, 210 insertions(+), 114 deletions(-)
>  create mode 100755 images/guest-aux/make-fedora-img.pl
>  delete mode 100755 images/guest-aux/make-fedora-img.sh
> 

Applied this patch by *patch -p1 < xxx* will lost the *file mode*.
So, I'd like to use *git send-email* without patch attached.

Or, did I miss something?

Thanks
-Wanlong Gao
> 
> 
> 
> _______________________________________________
> Libguestfs mailing list
> Libguestfs at redhat.com
> https://www.redhat.com/mailman/listinfo/libguestfs