Libguestfs - Mar 2010 - [PATCH virt-v2v] Remove useless use of 'use_windows_registry' flag.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
libguestfs lets you edit virtual machines.  Supports shell scripting,
bindings from many languages.  http://et.redhat.com/~rjones/libguestfs/
See what it can do: http://et.redhat.com/~rjones/libguestfs/recipes.html
-------------- next part --------------
>From ebb99ee14b5e44b5614ab1c9ca76482f9c81f7b0 Mon Sep 17 00:00:00 2001
From: Richard Jones <rjones at redhat.com>
Date: Mon, 8 Mar 2010 16:20:10 +0000
Subject: [PATCH] Remove useless use of 'use_windows_registry' flag.

It was effectively doing this:
  Sys::Guestfs::Lib::inspect_all_partitions (...,
                      use_windows_registry => undef);
That has no effect, and in any case I'm going to remove that
flag from inspect_all_partitions in a future release of libguestfs.
---
 v2v/virt-v2v.pl |    5 +----
 1 files changed, 1 insertions(+), 4 deletions(-)

diff --git a/v2v/virt-v2v.pl b/v2v/virt-v2v.pl
index cf73fbb..33e65f3 100755
--- a/v2v/virt-v2v.pl
+++ b/v2v/virt-v2v.pl
@@ -405,15 +405,12 @@ sub inspect_guest
 {
     my $g = shift;
 
-    my $use_windows_registry;
-
     # List of possible filesystems.
     my @partitions = get_partitions ($g);
 
     # Now query each one to build up a picture of what's in it.
     my %fses -        inspect_all_partitions ($g, \@partitions,
-                                use_windows_registry =>
$use_windows_registry);
+        inspect_all_partitions ($g, \@partitions);
 
     #print "fses -----------\n";
     #print Dumper(\%fses);
-- 
1.6.5.2

On 08/03/10 16:23, Richard W.M. Jones wrote:
> From ebb99ee14b5e44b5614ab1c9ca76482f9c81f7b0 Mon Sep 17 00:00:00 2001
> From: Richard Jones <rjones at redhat.com>
> Date: Mon, 8 Mar 2010 16:20:10 +0000
> Subject: [PATCH] Remove useless use of 'use_windows_registry' flag.
> 
> It was effectively doing this:
>   Sys::Guestfs::Lib::inspect_all_partitions (...,
>                       use_windows_registry => undef);
> That has no effect, and in any case I'm going to remove that
> flag from inspect_all_partitions in a future release of libguestfs.
> ---
>  v2v/virt-v2v.pl |    5 +----
>  1 files changed, 1 insertions(+), 4 deletions(-)
> 
ACK.

Matt
-- 
Matthew Booth, RHCA, RHCSS
Red Hat Engineering, Virtualisation Team

M:       +44 (0)7977 267231
GPG ID:  D33C3490
GPG FPR: 3733 612D 2D05 5458 8A8A 1600 3441 EA19 D33C 3490