Matthew Booth
2009-Dec-16 15:03 UTC
[Libguestfs] [PATCH] GuestOS: Fix [aliases] not parsed unless [deps] is specified
A cut/paste error in GuestOS.pm meant that aliases specified in the config file
would be ignored unless the config file also had a [deps] section.
---
lib/Sys/VirtV2V/GuestOS.pm | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/lib/Sys/VirtV2V/GuestOS.pm b/lib/Sys/VirtV2V/GuestOS.pm
index 60d62ed..1db7590 100644
--- a/lib/Sys/VirtV2V/GuestOS.pm
+++ b/lib/Sys/VirtV2V/GuestOS.pm
@@ -188,7 +188,7 @@ sub configure
# Populate aliases from the [aliases] config section
my $aliases_conf = $config->{aliases};
- if(defined($deps_conf)) {
+ if(defined($aliases_conf)) {
# Copy the aliases_conf hash into %aliases
foreach my $label (keys(%$aliases_conf)) {
$aliases{$label} = $aliases_conf->{$label};
--
1.6.5.2
Richard W.M. Jones
2009-Dec-16 15:06 UTC
[Libguestfs] [PATCH] GuestOS: Fix [aliases] not parsed unless [deps] is specified
On Wed, Dec 16, 2009 at 03:03:49PM +0000, Matthew Booth wrote:> A cut/paste error in GuestOS.pm meant that aliases specified in the config file > would be ignored unless the config file also had a [deps] section. > --- > lib/Sys/VirtV2V/GuestOS.pm | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/lib/Sys/VirtV2V/GuestOS.pm b/lib/Sys/VirtV2V/GuestOS.pm > index 60d62ed..1db7590 100644 > --- a/lib/Sys/VirtV2V/GuestOS.pm > +++ b/lib/Sys/VirtV2V/GuestOS.pm > @@ -188,7 +188,7 @@ sub configure > # Populate aliases from the [aliases] config section > my $aliases_conf = $config->{aliases}; > > - if(defined($deps_conf)) { > + if(defined($aliases_conf)) { > # Copy the aliases_conf hash into %aliases > foreach my $label (keys(%$aliases_conf)) { > $aliases{$label} = $aliases_conf->{$label}; > -- > 1.6.5.2ACK, obvious mistake. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-df lists disk usage of guests without needing to install any software inside the virtual machine. Supports Linux and Windows. http://et.redhat.com/~rjones/virt-df/