Richard W.M. Jones
2009-Nov-24 14:30 UTC
[Libguestfs] [PATCH] availability: Clarify and fix documentation.
-- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones New in Fedora 11: Fedora Windows cross-compiler. Compile Windows programs, test, and build Windows installers. Over 70 libraries supprt'd http://fedoraproject.org/wiki/MinGW http://www.annexia.org/fedora_mingw -------------- next part -------------->From 59b13c6145cdd59fee78824769fffb2686b2813f Mon Sep 17 00:00:00 2001From: Richard Jones <rjones at redhat.com> Date: Tue, 24 Nov 2009 14:00:34 +0000 Subject: [PATCH 2/4] availability: Clarify and fix documentation. --- src/generator.ml | 23 ++++++++++++----------- 1 files changed, 12 insertions(+), 11 deletions(-) diff --git a/src/generator.ml b/src/generator.ml index 1206be2..722e2f7 100755 --- a/src/generator.ml +++ b/src/generator.ml @@ -4109,24 +4109,24 @@ much more efficient to use C<guestfs_truncate_size>."); "test availability of some parts of the API", "\ This command is used to check the availability of some -groups of libguestfs functions which not all builds of -libguestfs will be able to provide. +groups of functionality in the appliance, which not all builds of +the libguestfs appliance will be able to provide. -The precise libguestfs function groups that may be checked by this -command are listed in L<guestfs(3)/AVAILABILITY>. +The libguestfs groups, and the functions that those +groups correspond to, are listed in L<guestfs(3)/AVAILABILITY>. -The argument C<groups> is a list of API group names, eg: +The argument C<groups> is a list of group names, eg: C<[\"inotify\", \"augeas\"]> would check for the availability of -the C<guestfs_inotify_*> functions and C<guestfs_aug_*> -(partition editing) functions. +the Linux inotify functions and Augeas (configuration file +editing) functions. The command returns no error if I<all> requested groups are available. -It returns an error if one or more of the requested -groups is unavailable. +It fails with an error if one or more of the requested +groups is unavailable in the appliance. If an unknown group name is included in the -list of C<groups> then an error is always returned. +list of groups then an error is always returned. I<Notes:> @@ -4135,7 +4135,8 @@ I<Notes:> =item * You must call C<guestfs_launch> before calling this function. -The reason is because we don't know what function groups are + +The reason is because we don't know what groups are supported by the appliance/daemon until it is running and can be queried. -- 1.6.5.2
Richard W.M. Jones
2009-Nov-24 14:32 UTC
[Libguestfs] [PATCH] availability: Clarify and fix documentation.
Sorry, I meant to add a comment at the top of this patch. There's some question about whether this call should be called 'guestfs_available' or something else. Suggestions included (from me) 'guestfs_fail_if_unavailable'. I *didn't* make that change here, but if someone comes up with a good, short name, then there's still time to change it before we release a tarball and the ABI becomes fixed. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones New in Fedora 11: Fedora Windows cross-compiler. Compile Windows programs, test, and build Windows installers. Over 70 libraries supprt'd http://fedoraproject.org/wiki/MinGW http://www.annexia.org/fedora_mingw
Reasonably Related Threads
- [PATCH 0/7] Add libvirt domain to core API
- [PATCH febootstrap 0/8] Add support for building an ext2-based appliance
- Some more Virt-P2V CD results - screenshot attached as promised
- [PATCH 0/8 v2] Complete fix for CVE-2010-3851.
- [PATCH] Correct checks for dup failure in guestfs_launch