Jim Meyering
2009-Nov-20 13:30 UTC
[Libguestfs] [PATCH libguestfs] build: make autogen.sh update .git-module-status, as it should
I ran autogen.sh, but then make was always failing like this: $ make cfg.mk:141: *** gnulib update required; run ./autogen.sh first. Stop. Here's the fix:>From f743f32079fea2e8a17c7f5b59305e584c75dba0 Mon Sep 17 00:00:00 2001From: Jim Meyering <meyering at redhat.com> Date: Fri, 20 Nov 2009 14:29:55 +0100 Subject: [PATCH libguestfs] build: make autogen.sh update .git-module-status, as it should * autogen.sh: Without this, "make" would always say "gnulib update required; run ./autogen.sh first", even after you'd run autogen.sh successfully. --- autogen.sh | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/autogen.sh b/autogen.sh index b31ec7b..cbb6da8 100755 --- a/autogen.sh +++ b/autogen.sh @@ -24,7 +24,7 @@ set -v # Ensure that whenever we pull in a gnulib update or otherwise change to a # different version (i.e., when switching branches), we also rerun ./bootstrap. curr_status=.git-module-status -t=$(git submodule status) +t=$(git submodule status|sed 's/.//;s/ .*//') if test "$t" = "$(cat $curr_status 2>/dev/null)"; then : # good, it's up to date else -- 1.6.5.3.433.g11067
Richard W.M. Jones
2009-Nov-20 14:12 UTC
[Libguestfs] [PATCH libguestfs] build: make autogen.sh update .git-module-status, as it should
On Fri, Nov 20, 2009 at 02:30:57PM +0100, Jim Meyering wrote:> I ran autogen.sh, but then make was always failing like this: > > $ make > cfg.mk:141: *** gnulib update required; run ./autogen.sh first. Stop.[...] Thanks, ACKed and pushed. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-df lists disk usage of guests without needing to install any software inside the virtual machine. Supports Linux and Windows. http://et.redhat.com/~rjones/virt-df/
Apparently Analagous Threads
- [PATCH libguestfs] build: correct sed transformation to work also on .git-module-status
- [PATCH libguestfs] accommodate leading "+" in git submodule output
- use gnulib, and begin to pass its "make syntax-check" tests
- [PATCH libguestfs] build: revive the ocaml package tests
- [PATCH libguestfs 1/2] build: invoke autopoint and autoreconf with --force