LARTC - Nov 2004 - [PATCH] [TRY2] Use nfmark as a key in u32 classifier

Hello!

This is the try number two.
What was changed:
- Added selectable choice in Kconfig file (thanks Jamal!)
- Don''t abuse tc_u32_sel to not break backward compatibility (thanks 
Patrick!).

Stephen, do you have any comments on iproute2 part? I know it''s not 
perfect but this is the best way, I think. "u32 match mark vvvv mmmm"
it''s
intuitive but breaks a little the levels, "u32 mark vvvv mmmm"
it''s ok
but not intuitive....
If you want I can rewrite it if you want.

Thank you for your time.

Signed-off-by: Catalin(ux aka Dino) <catab at umbrella.ro>

---
Catalin(ux aka Dino) BOIE
catab at deuroconsult.ro
http://kernel.umbrella.ro/

Looks quiet palatable. You didnt CC Dave for inclusion

cheers,
jamal

On Tue, 2004-11-09 at 07:27, Catalin(ux aka Dino) BOIE
wrote:
> Hello!
> 
> This is the try number two.
> What was changed:
> - Added selectable choice in Kconfig file (thanks Jamal!)
> - Don''t abuse tc_u32_sel to not break backward compatibility
(thanks
> Patrick!).
> 
> Stephen, do you have any comments on iproute2 part? I know it''s
not
> perfect but this is the best way, I think. "u32 match mark vvvv
mmmm" it''s
> intuitive but breaks a little the levels, "u32 mark vvvv mmmm"
it''s ok
> but not intuitive....
> If you want I can rewrite it if you want.
> 
> Thank you for your time.
> 
> Signed-off-by: Catalin(ux aka Dino) <catab at umbrella.ro>
> 
> ---
> Catalin(ux aka Dino) BOIE
> catab at deuroconsult.ro
> http://kernel.umbrella.ro/
-
To unsubscribe from this list: send the line "unsubscribe linux-net"
in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

On Tue, 9 Nov 2004, jamal wrote:
>
> Looks quiet palatable. You didnt CC Dave for inclusion
Yes, I tought that he reads evry message on netdev...
I added him, thanks.

Dave, please, include it in next release.
Thank you.
>
> cheers,
> jamal
>
> On Tue, 2004-11-09 at 07:27, Catalin(ux aka Dino) BOIE wrote:
>> Hello!
>>
>> This is the try number two.
>> What was changed:
>> - Added selectable choice in Kconfig file (thanks Jamal!)
>> - Don''t abuse tc_u32_sel to not break backward compatibility
(thanks
>> Patrick!).
>>
>> Stephen, do you have any comments on iproute2 part? I know
it''s not
>> perfect but this is the best way, I think. "u32 match mark vvvv
mmmm" it''s
>> intuitive but breaks a little the levels, "u32 mark vvvv
mmmm" it''s ok
>> but not intuitive....
>> If you want I can rewrite it if you want.
>>
>> Thank you for your time.
>>
>> Signed-off-by: Catalin(ux aka Dino) <catab at umbrella.ro>
>>
>> ---
>> Catalin(ux aka Dino) BOIE
>> catab at deuroconsult.ro
>> http://kernel.umbrella.ro/
>
---
Catalin(ux aka Dino) BOIE
catab at deuroconsult.ro
http://kernel.umbrella.ro/
-
To unsubscribe from this list: send the line "unsubscribe linux-net"
in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

* Catalin(ux aka Dino) BOIE
<Pine.LNX.4.61.0411091406570.20094@webhosting.rdsbv.ro> 2004-11-09
14:27
> This is the try number two.
> What was changed:
> - Added selectable choice in Kconfig file (thanks Jamal!)
> - Don''t abuse tc_u32_sel to not break backward compatibility
(thanks
> Patrick!).
Your patchs looks fine except for missing dependcy on CONFIG_NETFILTER.
Either make CLS_U32_MARK dependant on it or #ifdef the references
to skb->nfmark.

It might be fair to tell you that this code is likely to be removed
again once we have the metadata match.

Cheers
-
To unsubscribe from this list: send the line "unsubscribe linux-net"
in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

> * Catalin(ux aka Dino) BOIE
<Pine.LNX.4.61.0411091406570.20094@webhosting.rdsbv.ro> 2004-11-09 14:27
>> This is the try number two.
>> What was changed:
>> - Added selectable choice in Kconfig file (thanks Jamal!)
>> - Don''t abuse tc_u32_sel to not break backward compatibility
(thanks
>> Patrick!).
>
> Your patchs looks fine except for missing dependcy on CONFIG_NETFILTER.
> Either make CLS_U32_MARK dependant on it or #ifdef the references
> to skb->nfmark.
Patch updated and attached.
> It might be fair to tell you that this code is likely to be removed
> again once we have the metadata match.
Jamal already warned me about this.
Is somebody already working on it?
> Cheers
Thank you!
---
Catalin(ux aka Dino) BOIE
catab at deuroconsult.ro
http://kernel.umbrella.ro/