Hello! Why in kernel in net/sched/sch_sfq.c and in other places (htb) the change function is not sfq_change (or htb_change) and is NULL instead? Thank you very much! --- Catalin(ux) BOIE catab@deuroconsult.ro http://www2.deuroconsult.ro/~catab
Because there is nothing to change once created. For HTB it might be r2q or debug but there is no real need yet. devik On Thu, 9 May 2002, Catalin BOIE wrote:> Hello! > > Why in kernel in net/sched/sch_sfq.c and in other places (htb) the change > function is not sfq_change (or htb_change) and is NULL instead? > > Thank you very much! > > --- > Catalin(ux) BOIE > catab@deuroconsult.ro > http://www2.deuroconsult.ro/~catab > > _______________________________________________ > LARTC mailing list / LARTC@mailman.ds9a.nl > http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://lartc.org/ > >
On Thu, 9 May 2002, Martin Devera wrote:> Date: Thu, 9 May 2002 12:29:00 +0200 (CEST) > From: Martin Devera <devik@cdi.cz> > To: Catalin BOIE <catab@deuroconsult.ro> > Cc: lartc@mailman.ds9a.nl > Subject: Re: [LARTC] htb_change sfq_change > > Because there is nothing to change once created. For HTB > it might be r2q or debug but there is no real need yet. > devikOK. But for SFQ?> > On Thu, 9 May 2002, Catalin BOIE wrote: > > > Hello! > > > > Why in kernel in net/sched/sch_sfq.c and in other places (htb) the change > > function is not sfq_change (or htb_change) and is NULL instead? > > > > Thank you very much! > > > > --- > > Catalin(ux) BOIE > > catab@deuroconsult.ro > > http://www2.deuroconsult.ro/~catab > > > > _______________________________________________ > > LARTC mailing list / LARTC@mailman.ds9a.nl > > http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://lartc.org/ > > > > >--- Catalin(ux) BOIE catab@deuroconsult.ro http://www2.deuroconsult.ro/~catab
On Thu, 9 May 2002, Martin Devera wrote:> Date: Thu, 9 May 2002 12:29:00 +0200 (CEST) > From: Martin Devera <devik@cdi.cz> > To: Catalin BOIE <catab@deuroconsult.ro> > Cc: lartc@mailman.ds9a.nl > Subject: Re: [LARTC] htb_change sfq_change > > Because there is nothing to change once created. For HTB > it might be r2q or debug but there is no real need yet. > devikIt''s hard to implement it? Thanks!> > On Thu, 9 May 2002, Catalin BOIE wrote: > > > Hello! > > > > Why in kernel in net/sched/sch_sfq.c and in other places (htb) the change > > function is not sfq_change (or htb_change) and is NULL instead? > > > > Thank you very much! > > > > --- > > Catalin(ux) BOIE > > catab@deuroconsult.ro > > http://www2.deuroconsult.ro/~catab > > > > _______________________________________________ > > LARTC mailing list / LARTC@mailman.ds9a.nl > > http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://lartc.org/ > > > > > > _______________________________________________ > LARTC mailing list / LARTC@mailman.ds9a.nl > http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://lartc.org/ >--- Catalin(ux) BOIE catab@deuroconsult.ro http://www2.deuroconsult.ro/~catab
Should not be. But HTB is in feature freeze. My main goal is to be in kernel asap. Then we can do some changes later. I''d like to keep the code from larger updates now. Do you need it ? And why ? devik On Fri, 10 May 2002, Catalin BOIE wrote:> On Thu, 9 May 2002, Martin Devera wrote: > > > Date: Thu, 9 May 2002 12:29:00 +0200 (CEST) > > From: Martin Devera <devik@cdi.cz> > > To: Catalin BOIE <catab@deuroconsult.ro> > > Cc: lartc@mailman.ds9a.nl > > Subject: Re: [LARTC] htb_change sfq_change > > > > Because there is nothing to change once created. For HTB > > it might be r2q or debug but there is no real need yet. > > devik > > It''s hard to implement it? > Thanks! > > > > > On Thu, 9 May 2002, Catalin BOIE wrote: > > > > > Hello! > > > > > > Why in kernel in net/sched/sch_sfq.c and in other places (htb) the change > > > function is not sfq_change (or htb_change) and is NULL instead? > > > > > > Thank you very much! > > > > > > --- > > > Catalin(ux) BOIE > > > catab@deuroconsult.ro > > > http://www2.deuroconsult.ro/~catab > > > > > > _______________________________________________ > > > LARTC mailing list / LARTC@mailman.ds9a.nl > > > http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://lartc.org/ > > > > > > > > > > _______________________________________________ > > LARTC mailing list / LARTC@mailman.ds9a.nl > > http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://lartc.org/ > > > > --- > Catalin(ux) BOIE > catab@deuroconsult.ro > http://www2.deuroconsult.ro/~catab > > >
> > OK. > But for SFQ?what do you want to change in sfq !!?? devik
> Should not be. But HTB is in feature freeze. My main > goal is to be in kernel asap.I wish you good luck! HTB deserves to be in the main kernel tree.> Then we can do some changes later. I''d like to keep the > code from larger updates now.OK.> Do you need it ? And why ?Yes, I need it. I need to change on the fly r2q to see how the traffic flow changes. But I don''t want to delete the whole tree just to change some parameters on the root class.> devik > > On Fri, 10 May 2002, Catalin BOIE wrote: > > > On Thu, 9 May 2002, Martin Devera wrote: > > > > > Date: Thu, 9 May 2002 12:29:00 +0200 (CEST) > > > From: Martin Devera <devik@cdi.cz> > > > To: Catalin BOIE <catab@deuroconsult.ro> > > > Cc: lartc@mailman.ds9a.nl > > > Subject: Re: [LARTC] htb_change sfq_change > > > > > > Because there is nothing to change once created. For HTB > > > it might be r2q or debug but there is no real need yet. > > > devik > > > > It''s hard to implement it? > > Thanks! > > > > > > > > On Thu, 9 May 2002, Catalin BOIE wrote: > > > > > > > Hello! > > > > > > > > Why in kernel in net/sched/sch_sfq.c and in other places (htb) the change > > > > function is not sfq_change (or htb_change) and is NULL instead? > > > > > > > > Thank you very much! > > > > > > > > --- > > > > Catalin(ux) BOIE > > > > catab@deuroconsult.ro > > > > http://www2.deuroconsult.ro/~catab > > > > > > > > _______________________________________________ > > > > LARTC mailing list / LARTC@mailman.ds9a.nl > > > > http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://lartc.org/ > > > > > > > > > > > > > > _______________________________________________ > > > LARTC mailing list / LARTC@mailman.ds9a.nl > > > http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://lartc.org/ > > > > > > > --- > > Catalin(ux) BOIE > > catab@deuroconsult.ro > > http://www2.deuroconsult.ro/~catab > > > > > > >--- Catalin(ux) BOIE catab@deuroconsult.ro http://www2.deuroconsult.ro/~catab
> > OK. > > But for SFQ? > > what do you want to change in sfq !!??perturb and quantum on-the-fly.> devik--- Catalin(ux) BOIE catab@deuroconsult.ro http://www2.deuroconsult.ro/~catab
> I wish you good luck! > HTB deserves to be in the main kernel tree.Thanks :)> > Do you need it ? And why ? > Yes, I need it. > I need to change on the fly r2q to see how the traffic flow changes. > But I don''t want to delete the whole tree just to change some parameters > on the root class.you can''t do it either. The r2q is used ONLY during class creation to compute its default quantum. To test your case you would need to call tc class change for all existing classes. devik
:) You can drop & recreate it safely. User will not see it. The change function for SFQ will be probably considered "redundant" by other kernel developers because of it. On Tue, 14 May 2002, Catalin BOIE wrote:> > > OK. > > > But for SFQ? > > > > what do you want to change in sfq !!?? > perturb and quantum on-the-fly. > > > devik > > --- > Catalin(ux) BOIE > catab@deuroconsult.ro > http://www2.deuroconsult.ro/~catab > > >
On Tue, 14 May 2002, Martin Devera wrote:> Date: Tue, 14 May 2002 14:15:36 +0200 (CEST) > From: Martin Devera <devik@cdi.cz> > To: Catalin BOIE <catab@deuroconsult.ro> > Cc: lartc@mailman.ds9a.nl > Subject: Re: [LARTC] htb_change sfq_change > > :) You can drop & recreate it safely. User will > not see it. The change function for SFQ will be > probably considered "redundant" by other kernel > developers because of it.But you loose counters! This is bad IMHO.> > On Tue, 14 May 2002, Catalin BOIE wrote: > > > > > OK. > > > > But for SFQ? > > > > > > what do you want to change in sfq !!?? > > perturb and quantum on-the-fly. > > > > > devik > > > > --- > > Catalin(ux) BOIE > > catab@deuroconsult.ro > > http://www2.deuroconsult.ro/~catab > > > > > > >--- Catalin(ux) BOIE catab@deuroconsult.ro openh323://dino.rdsbv.ro
On Wed, May 15, 2002 at 02:24:54PM +0300, Catalin BOIE wrote:> On Tue, 14 May 2002, Martin Devera wrote: > But you loose counters! This is bad IMHO.If you know when you''re dropping it, the counter loss is not relevant; resetting to zero is easy to compensate for, and rrdtool (for example) has built-in support for it. As per the rrdtool developper''s recommendations, I have the following in front of my QoS reset script: rrdtool update /var/rrd/qos_office.rrd N:U:U:U:U rrdtool update /var/rrd/qos_office.rrd N:0:0:0:0 ... done for each rrd file. -- Michael T. Babcock CTO, FibreSpeed Ltd. (Hosting, Security, Consultation, Database, etc) http://www.fibrespeed.net/~mbabcock/
> > :) You can drop & recreate it safely. User will > > not see it. The change function for SFQ will be > > probably considered "redundant" by other kernel > > developers because of it. > > But you loose counters! This is bad IMHO.That''s good point ! So that go ahead and implement it for SFQ :)
On Wed, 15 May 2002, Martin Devera wrote:> Date: Wed, 15 May 2002 15:11:09 +0200 (CEST) > From: Martin Devera <devik@cdi.cz> > To: Catalin BOIE <catab@deuroconsult.ro> > Cc: lartc@mailman.ds9a.nl > Subject: Re: [LARTC] htb_change sfq_change > > > > :) You can drop & recreate it safely. User will > > > not see it. The change function for SFQ will be > > > probably considered "redundant" by other kernel > > > developers because of it. > > > > But you loose counters! This is bad IMHO. > > That''s good point ! So that go ahead and implement it for > SFQ :)But it is already! But in sch_sfq.c at the end (in jump table) is "NULL /* sfq_change */"! There are race problems in sfq_change? I found a patch on the net that puted NULL instead sfq_change... Thanks! --- Catalin(ux) BOIE catab@deuroconsult.ro openh323://dino.rdsbv.ro