Ben Hutchings
2026-Feb-03 16:35 UTC
[klibc] [PATCH 1/2] explicitly close arm64 syscall stub generator output
On Sat, 2026-01-31 at 17:14 -0800, Greg Thelen wrote:> The output of syscalls.pl pass 2 includes: > 1) A makefile fragment written to stdout. This is redirected by the > caller to syscalls.mk. The format is: > syscall-objs := <list of per syscall .o files, like recvmsg.o) > 2) Syscall stub files such as recvmsg.S. These are written using > per-arch stubs generator, e.g., usr/klibc/arch/arm64/sysstub.ph. > > The usr/klibc/syscalls/Kbuild makefile: > - includes syscalls.mk > - defines syscalls.mk to depend on .S files for each > syscall-objs, e.g., recvmsg.S[...] This shouldn't be true after your patch "[klibc] remove unneeded syscalls.mk dependencies", so are these 2 really still needed? Ben. -- Ben Hutchings Any sufficiently advanced bug is indistinguishable from a feature. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 833 bytes Desc: This is a digitally signed message part URL: <https://lists.zytor.com/archives/klibc/attachments/20260203/23171868/attachment.sig>
Greg Thelen
2026-Feb-03 17:08 UTC
[klibc] [PATCH 1/2] explicitly close arm64 syscall stub generator output
On Tue, Feb 3, 2026 at 8:35?AM Ben Hutchings <ben at decadent.org.uk> wrote:> > On Sat, 2026-01-31 at 17:14 -0800, Greg Thelen wrote: > > The output of syscalls.pl pass 2 includes: > > 1) A makefile fragment written to stdout. This is redirected by the > > caller to syscalls.mk. The format is: > > syscall-objs := <list of per syscall .o files, like recvmsg.o) > > 2) Syscall stub files such as recvmsg.S. These are written using > > per-arch stubs generator, e.g., usr/klibc/arch/arm64/sysstub.ph. > > > > The usr/klibc/syscalls/Kbuild makefile: > > - includes syscalls.mk > > - defines syscalls.mk to depend on .S files for each > > syscall-objs, e.g., recvmsg.S > [...] > > This shouldn't be true after your patch "[klibc] remove unneeded > syscalls.mk dependencies", so are these 2 really still needed?I assumed this change would be applied first, which case this commit log would be accurate. I should've grouped them into the same series to make it clearer. You are correct that if "[klibc] remove unneeded syscalls.mk dependencies" is applied first, then this commit log claim is stale. In that case, this patch becomes a lower priority cleanup. It would still be useful to make the arm* stubs consistent with other architecture stubs. My recommended order of patches is: 1. [klibc] explicitly close arm64 syscall stub generator output 2. [klibc] explicitly close arm syscall stub generator output 3. [klibc] remove unneeded syscalls.mk dependencies 4. [klibc] fix arm stub alignment But I'm happy to rewrite the commit logs if you'd prefer to drop or reorder 1 and 2.> Ben. > > -- > Ben Hutchings > Any sufficiently advanced bug is indistinguishable from a feature.