Greg Thelen
2026-Feb-01 01:15 UTC
[klibc] [PATCH] remove unneeded syscalls.mk dependencies
The syscalls.mk build rule (syscalls.pl pass 2):
- Generates .S stub files. It does not read them.
- Does not read syscommon.h.
So remove the unneeded dependencies from Kbuild. No behavioral
change. This is just a cleanup.
Fixes: f2baaf24acdc ("Add missing kbuild files")
Signed-off-by: Greg Thelen <gthelen at google.com>
---
usr/klibc/syscalls/Kbuild | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/usr/klibc/syscalls/Kbuild b/usr/klibc/syscalls/Kbuild
index 3f567989523b..9d2d81b1035c 100644
--- a/usr/klibc/syscalls/Kbuild
+++ b/usr/klibc/syscalls/Kbuild
@@ -91,9 +91,7 @@ quiet_cmd_syscalls = GEN $@
$(obj)/syscalls.mk: $(srctree)/$(KLIBCSRC)/syscalls.pl $(obj)/SYSCALLS.i \
$(srctree)/$(KLIBCSRC)/arch/$(KLIBCARCHDIR)/sysstub.ph \
- $(call objectify, $(syscall-objs:.o=.S)) \
- $(src)/syscommon.h $(obj)/syscalls.nrs \
- $(obj)/typesize.bin FORCE
+ $(obj)/syscalls.nrs $(obj)/typesize.bin FORCE
$(call if_changed,syscalls)
PHONY += FORCE
--
2.53.0.rc1.225.gd81095ad13-goog
Ben Hutchings
2026-Feb-03 16:04 UTC
[klibc] [PATCH] remove unneeded syscalls.mk dependencies
On Sat, 2026-01-31 at 17:15 -0800, Greg Thelen wrote:> The syscalls.mk build rule (syscalls.pl pass 2): > - Generates .S stub files. It does not read them. > - Does not read syscommon.h. > > So remove the unneeded dependencies from Kbuild. No behavioral > change. This is just a cleanup. > > Fixes: f2baaf24acdc ("Add missing kbuild files") > Signed-off-by: Greg Thelen <gthelen at google.com>Applied, thanks. Ben.> --- > usr/klibc/syscalls/Kbuild | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/usr/klibc/syscalls/Kbuild b/usr/klibc/syscalls/Kbuild > index 3f567989523b..9d2d81b1035c 100644 > --- a/usr/klibc/syscalls/Kbuild > +++ b/usr/klibc/syscalls/Kbuild > @@ -91,9 +91,7 @@ quiet_cmd_syscalls = GEN $@ > > $(obj)/syscalls.mk: $(srctree)/$(KLIBCSRC)/syscalls.pl $(obj)/SYSCALLS.i \ > $(srctree)/$(KLIBCSRC)/arch/$(KLIBCARCHDIR)/sysstub.ph \ > - $(call objectify, $(syscall-objs:.o=.S)) \ > - $(src)/syscommon.h $(obj)/syscalls.nrs \ > - $(obj)/typesize.bin FORCE > + $(obj)/syscalls.nrs $(obj)/typesize.bin FORCE > $(call if_changed,syscalls) > > PHONY += FORCE-- Ben Hutchings Any sufficiently advanced bug is indistinguishable from a feature. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 833 bytes Desc: This is a digitally signed message part URL: <https://lists.zytor.com/archives/klibc/attachments/20260203/6f77ce07/attachment.sig>