klibc-bot for Ben Hutchings
2019-Oct-07 18:21 UTC
[klibc] [klibc:master] Fix missing header dependency for sigsuspend.o
Commit-ID: 5b7689f66c4476432ebe8fe8a88ea9fdeaa4eba8 Gitweb: http://git.kernel.org/?p=libs/klibc/klibc.git;a=commit;h=5b7689f66c4476432ebe8fe8a88ea9fdeaa4eba8 Author: Ben Hutchings <ben at decadent.org.uk> AuthorDate: Mon, 7 Oct 2019 16:49:35 +0100 Committer: Ben Hutchings <ben at decadent.org.uk> CommitDate: Mon, 7 Oct 2019 17:25:17 +0100 [klibc] Fix missing header dependency for sigsuspend.o sigsuspend.c includes <klibc/havesyscall.h>, which is a generated file. In a parallel make, sigsuspend.o might currently be built before havesyscall.h, and to avoid this we need t add an explicit dependency. Given that they are built from different makefiles, I don't think a direct dependency will work. Instead, add syscalls/klib.list as a dependency for sigsuspend.o so that it indirectly depends on everything that's built from syscalls/. Reported-by: Matthias Klose <doko at ubuntu.com> Reported-by: Thorsten Glaser <tg at mirbsd.de> References: https://bugs.launchpad.net/ubuntu/+source/klibc/+bug/1843743 Signed-off-by: Ben Hutchings <ben at decadent.org.uk> --- usr/klibc/Kbuild | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/usr/klibc/Kbuild b/usr/klibc/Kbuild index 526442dc..b462fbec 100644 --- a/usr/klibc/Kbuild +++ b/usr/klibc/Kbuild @@ -83,6 +83,10 @@ ifeq ($(CONFIG_KLIBC_ERRLIST),y) KLIBCCFLAGS_strerror.o += -DWITH_ERRLIST endif +# sigsuspend.c includes <klibc/havesyscall.h> generated by syscalls/ +# build, so require that to build first +$(obj)/sigsuspend.o: $(obj)/syscalls/klib.list + ##### # Shared definitions LIBC := libc.a