H. Peter Anvin
2013-Dec-27 04:31 UTC
[klibc] [PATCH] Update header locations for uapi & generated
On 12/26/2013 07:27 PM, Robin H. Johnson wrote:> (please CC me, I'm not on the klibc list, and I didn't get HPA's > response to my post). > > On Fri, Dec 27, 2013 at 12:24:34AM +0000, Thorsten Glaser wrote: >> H. Peter Anvin dixit: >>> You should be using the output of "make headers_install" to build klibc. > That makes easy cross-building a pain in the arse, and if that's the > case, why do you even have variables referring to the kernel source at > all? KLIBCKERNELSRC is a local copy of the kernel for our build > purposes. > > Aside from the build spewing: > #warning "Attempt to use kernel headers from user space, see http://kernelnewbies.org/KernelHeaders" > There is nothing wrong with the build, and it passes all of your > testcases (we block some of them as they would fail in the non-root > restricted environment, but they pass outside that). > > http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/dev-libs/klibc/klibc-2.0.3-r1.ebuild?revision=1.1&view=markup > > I'm perfectly happy to use the result of headers_install, but there is > no way to specify where that output is. I do NOT want the /usr/include > location used, we'd be doing a pass of headers_install with > INSTALL_HDR_PATH="${S}"/linux-headers/ and wanting to point klibc to > that location for the build. > > In the end, demanding that I use a copy of the installed kernel headers, > when I'm passing a specific kernel source to the klibc build and that > kernel source is most probably not the same as the kernel that's running > seems like a bad idea. I want to build against a known kernel source, > and not expose klibc to the crazy kernels used by some gentoo users. >Please read the *current* version of usr/klibc/README.klibc and come back. -hpa
Robin H. Johnson
2013-Dec-27 04:49 UTC
[klibc] [PATCH] Update header locations for uapi & generated
On Thu, Dec 26, 2013 at 08:31:48PM -0800, H. Peter Anvin wrote:> > In the end, demanding that I use a copy of the installed kernel headers, > > when I'm passing a specific kernel source to the klibc build and that > > kernel source is most probably not the same as the kernel that's running > > seems like a bad idea. I want to build against a known kernel source, > > and not expose klibc to the crazy kernels used by some gentoo users. > Please read the *current* version of usr/klibc/README.klibc and come back.Those instructions fail, unless my patch is included: S is ${WORKDIR}/klibc-2.0.3 ${S}/linux is a symlink to ${WORKDIR}/linux-3.12, copy of the kernel sources, configured. in the kernel dir: emake headers_install INSTALL_HDR_PATH="${WORKDIR}"/linux-headers/ in the klibc dir: emake V=1 KLIBCKERNELSRC="${S}/linux/usr" (plus the rest of the opts) and the failure: x86_64-pc-linux-gnu-gcc -Wp,-MD,usr/klibc/.vsprintf.o.d -nostdinc -iwithprefix include -I/dev/shm/portage/dev-libs/klibc-2.0.3-r1/work/klibc-2.0.3/usr/include/arch/x86_64 -Iusr/include/arch/x86_64 -I/dev/shm/portage/dev-libs/klibc-2.0.3-r1/work/klibc-2.0.3/usr/include/bits64 -Iusr/include/bits64 -I/dev/shm/portage/dev-libs/klibc-2.0.3-r1/work/klibc-2.0.3/usr/klibc/../include -Iusr/klibc/../include -I/dev/shm/portage/dev-libs/klibc-2.0.3-r1/work/klibc-2.0.3/usr/include -Iusr/include -I/dev/shm/portage/dev-libs/klibc-2.0.3-r1/work/klibc-2.0.3/linux/usr/include -I/dev/shm/portage/dev-libs/klibc-2.0.3-r1/work/klibc-2.0.3/linux/usr/arch/x86/include -D__KLIBC__=2 -D__KLIBC_MINOR__=0 -D_BITSIZE=64 -fno-stack-protector -fwrapv -m64 -nostdlib -W -Wall -Wno-sign-compare -Wno-unused-parameter -c -o usr/klibc/vsprintf.o usr/klibc/vsprintf.c In file included from usr/klibc/vsnprintf.c:12:0: /dev/shm/portage/dev-libs/klibc-2.0.3-r1/work/klibc-2.0.3/usr/klibc/../include/limits.h:43:26: fatal error: linux/limits.h: No such file or directory #include <linux/limits.h> -- Robin Hugh Johnson Gentoo Linux: Developer, Infrastructure Lead E-Mail : robbat2 at gentoo.org GnuPG FP : 11ACBA4F 4778E3F6 E4EDF38E B27B944E 34884E85
H. Peter Anvin
2013-Dec-27 05:04 UTC
[klibc] [PATCH] Update header locations for uapi & generated
On 12/26/2013 08:49 PM, Robin H. Johnson wrote:> > in the kernel dir: > emake headers_install INSTALL_HDR_PATH="${WORKDIR}"/linux-headers/You are overriding INSTALL_HDR_PATH...> in the klibc dir: > emake V=1 KLIBCKERNELSRC="${S}/linux/usr" (plus the rest of the opts)... and then you point KLIBCKERNELSRC (which arguably is misnamed these days, but changing it would break other people) elsewhere. -hpa
Maybe Matching Threads
- [PATCH] Update header locations for uapi & generated
- [PATCH] Update header locations for uapi & generated
- [PATCH] Update header locations for uapi & generated
- [PATCH] Update header locations for uapi & generated
- Code inconsistency between release version and git in rsync-3.0.9