klibc - Feb 2006 - [rfc patch] mman.h remove asm/page.h include

klibc fails to compile on sparc64 since the kbuild switch:
In file included from include/sys/mman.h:11,
                 from klibc/malloc.c:8:
linux/include/asm/page.h:18:2: error: #error No page size specified in kernel
configuration

the current dirty build hack is to define CONFIG_SPARC64_PAGE_SIZE_8KB
in the sparc64 MCONFIG.

belows patch removes the asm/page.h include.
another way to fix that would be to move the __KERNEL__ definition up
in the asm-sparc64/page.h, i'm not sure which is preferrable.

warning: belows patch is only compile and runtime tested on x86,
but i didn't see any PAGE_SIZE usage in the klibc tree..

please tell which way is preferred and i get this patch more testing
or i'll do the other way round?

diff --git a/include/sys/mman.h b/include/sys/mman.h
index 7f8f3e2..f404188 100644
--- a/include/sys/mman.h
+++ b/include/sys/mman.h
@@ -8,7 +8,6 @@
 #include <klibc/extern.h>
 #include <sys/types.h>
 #include <asm/mman.h>
-#include <asm/page.h>		/* For PAGE_SIZE */
 
 #define MAP_FAILED ((void *)-1)

maximilian attems wrote:
> klibc fails to compile on sparc64 since the kbuild switch:
> In file included from include/sys/mman.h:11,
>                  from klibc/malloc.c:8:
> linux/include/asm/page.h:18:2: error: #error No page size specified in
kernel configuration
> 
> the current dirty build hack is to define CONFIG_SPARC64_PAGE_SIZE_8KB
> in the sparc64 MCONFIG.
Are you sure you did a "make config" on the tree beforehand?

	-hpa

H. Peter Anvin wrote:
> maximilian attems wrote:
> 
>> klibc fails to compile on sparc64 since the kbuild switch:
>> In file included from include/sys/mman.h:11,
>>                  from klibc/malloc.c:8:
>> linux/include/asm/page.h:18:2: error: #error No page size specified in 
>> kernel configuration
>>
>> the current dirty build hack is to define CONFIG_SPARC64_PAGE_SIZE_8KB
>> in the sparc64 MCONFIG.
> 
> Are you sure you did a "make config" on the tree beforehand?
> 
The kernel tree, that is.  "make config" and "make prepare"
are needed...

	-hpa