Skipped content of type multipart/mixed-------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 189 bytes Desc: This is a digitally signed message part Url : http://www.vas.nu/pipermail/klibc/attachments/20050825/0e6d8370/attachment.bin
On Thu, 2005-08-25 at 11:23 +0200, Martin Schlemmer wrote:> so it tries to compile with -fno-stack-protectorThis of course should have been -fstack-protector ... -- Martin Schlemmer -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 189 bytes Desc: This is a digitally signed message part Url : http://www.vas.nu/pipermail/klibc/attachments/20050825/0e146e51/attachment.bin
Martin Schlemmer wrote:> Hi, > > For our hardened profiles (gcc with SSP among things), its specs file > tries to figure out when it should disable SSP for kernel/whatever > builds by checking if -nostdlib was passed. KLIBC however do not pass > this, so it tries to compile with -fno-stack-protector, and then fails > to link as it cannot resolve the __guard, etc symbols (in glibc). > > http://bugs.gentoo.org/show_bug.cgi?id=103437 > > Any objection to attached patch? >I'd need to know what other effects -nostdlib has. If it's purely a linker flag it won't have any effect since klibc doesn't use gcc's linker, and then it's just fine; if it has other side effects it might not be a good thing. -hpa
Martin Schlemmer wrote:> Hi, > > For our hardened profiles (gcc with SSP among things), its specs file > tries to figure out when it should disable SSP for kernel/whatever > builds by checking if -nostdlib was passed. KLIBC however do not pass > this, so it tries to compile with -fno-stack-protector, and then fails > to link as it cannot resolve the __guard, etc symbols (in glibc). > > http://bugs.gentoo.org/show_bug.cgi?id=103437 > > Any objection to attached patch? >I have committed this; however, in the future, please don't send base64-encoded patches; I'd rather be able to use git-applymbox to get the author info correct. -hpa