Ironruby core - Sep 2010 - KCoding fix for Silverlight build (issue #5093)

Here''s my fix for a bug in the Silverlight build (issue
#5093<http://ironruby.codeplex.com/workitem/5093>
):
690730950522e4e65a0c<http://github.com/cstrahan/ironruby/commit/690730950522e4e65a0c069796dba2bb9300e60f>

-Charles
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://rubyforge.org/pipermail/ironruby-core/attachments/20100831/0bef6c12/attachment.html>

KCodings are obsolete and should be completely removed. So I don''t
think this needs to be fixed.

Besides Encoding.UTF8 is not a UTF8 singleton. You can create multiple different
UTF8Encoding instances. We should compare encoding CodePage but on Silverlight
that property is not availabl, so we need to compare encoding name.

Tomas

From: ironruby-core-bounces at rubyforge.org [mailto:ironruby-core-bounces at
rubyforge.org] On Behalf Of Charles Strahan
Sent: Tuesday, August 31, 2010 6:19 PM
To: ironruby-core at rubyforge.org
Subject: [Ironruby-core] KCoding fix for Silverlight build (issue #5093)

Here''s my fix for a bug in the Silverlight build (issue
#5093<http://ironruby.codeplex.com/workitem/5093>):
690730950522e4e65a0c<http://github.com/cstrahan/ironruby/commit/690730950522e4e65a0c069796dba2bb9300e60f>

-Charles
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://rubyforge.org/pipermail/ironruby-core/attachments/20100901/78a43923/attachment.html>

>
> KCodings are obsolete and should be completely removed. So I don?t think
> this needs to be fixed.
>
Sweet - that works for me :).

Have you had a chance to take a look at my other commit (regarding issue
#4946)?

-Charles

On Tue, Aug 31, 2010 at 8:28 PM, Tomas Matousek <
Tomas.Matousek at microsoft.com> wrote:
>  KCodings are obsolete and should be completely removed. So I don?t think
> this needs to be fixed.
>
>
>
> Besides Encoding.UTF8 is not a UTF8 singleton. You can create multiple
> different UTF8Encoding instances. We should compare encoding CodePage but
on
> Silverlight that property is not availabl, so we need to compare encoding
> name.
>
>
>
> Tomas
>
>
>
> *From:* ironruby-core-bounces at rubyforge.org [mailto:
> ironruby-core-bounces at rubyforge.org] *On Behalf Of *Charles Strahan
> *Sent:* Tuesday, August 31, 2010 6:19 PM
> *To:* ironruby-core at rubyforge.org
> *Subject:* [Ironruby-core] KCoding fix for Silverlight build (issue #5093)
>
>
>
> Here''s my fix for a bug in the Silverlight build (issue
#5093<http://ironruby.codeplex.com/workitem/5093>
> ):
>
690730950522e4e65a0c<http://github.com/cstrahan/ironruby/commit/690730950522e4e65a0c069796dba2bb9300e60f>
>
> -Charles
>
> _______________________________________________
> Ironruby-core mailing list
> Ironruby-core at rubyforge.org
> http://rubyforge.org/mailman/listinfo/ironruby-core
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://rubyforge.org/pipermail/ironruby-core/attachments/20100901/2b32c010/attachment.html>