tfpt review "/shelveset:gitsync;REDMOND\jdeville"
Comment :
sync from git:
commit 31501e7cac50ec624590d180b7da9fdec7d1a12f
Author: Jim Deville <jdeville at microsoft.com>
Date: Wed Jun 2 14:57:55 2010 -0700
moved gem shim to proper location
commit 4f252356198267c762f38f7d3cdef3944be7e564
Author: Ryan Riley <ryan at ryan-laptop.(none)>
Date: Fri Apr 16 23:03:38 2010 -0700
Updated rubyspecs for the Etc library.
Author: Ryan Riley <ryan at ryan-laptop.(none)>
commit c7f8951d4cdb09a5a4e1190a00bebc4f2cfc4581
Author: Jim Deville <jdeville at microsoft.com>
Date: Wed Jun 2 13:40:50 2010 -0700
Added the real etc.rb (oops) and correct passwd and getpwent specs.
Conflicts:
Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/librar
/etc/getpwent_spec.rb
Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/librar
/etc/passwd_spec.rb
commit d9c5c2c13742bd4c5490da415ac5b000e2fa7be0
Author: Ryan Riley <ryan at ryan-laptop.(none)>
Date: Sat Apr 10 08:05:59 2010 -0700
Added in the dev.sh and ir.sh scripts for mono. For some reason these
weren
t getting included in prior commits.
commit ceea1bb5db2f918d980e5b67a0a96cb185900883
Author: Ryan Riley <ryan at ryan-laptop.(none)>
Date: Sat Apr 10 07:47:48 2010 -0700
Added implementation of the Etc library, along with some updates to
RubySpe
. Also began work to fix file paths in testing facilities to allow tests to be
un on Mono.
Signed-off-by: unknown <jdeville at .redmond.corp.microsoft.com>
commit c38eef49ab93910c92d9aee94747e407ca5430f4
Author: Will Green <will at hotgazpacho.org>
Date: Tue May 25 03:23:34 2010 -0400
Gem::Platform objects, not strings, silly\!
commit 1755e7e33600fd6800a8a18f8cd7e764b9b1472d
Author: Will Green <will at hotgazpacho.org>
Date: Tue May 25 03:17:01 2010 -0400
Sigh. Need to explicitly add ''universal-unknown'' as a
platform, because rub
gems.org has not updated to rubygems 1.3.7 yet.
commit 7fa4051342b1c2574277ad52a8f929c9146840dd
Author: Will Green <will at hotgazpacho.org>
Date: Tue May 25 00:56:53 2010 -0400
Remove unnecessary platforms defaults
commit 0b3e45e7c6e18aec36dd01b4d378ac202823ccc6
Author: Will Green <will at hotgazpacho.org>
Date: Thu May 20 01:21:14 2010 -0400
report ruby, universal-dotnet, and universal-dotnet(FX-version) as
supporte
platforms
commit 8c0e99e482ccd097fa11a588f0f7150a84ad9f4a
Author: Will Green <will at hotgazpacho.org>
Date: Tue May 18 20:18:07 2010 -0400
Use gem defaults override to allow upgrading RubyGems
commit eeacc5b2becdc6f565383ac2f2cf9a0dd305ebb1
Author: zacbrown <zac at zacbrown.org>
Date: Sat Apr 10 20:47:51 2010 -0700
Add support for ?l (symlink) in Kernel.test and add mspec test.
commit f06a16eeb835f1409937cffc5acf3c039a81f0e3
Author: zacbrown <zac at zacbrown.org>
Date: Sat Apr 10 20:47:22 2010 -0700
Add support for ?k (sticky bit) in Kernel.test and add mspec test.
Requires
changes to the return value of RubyFileOps.RubyStatOps.IsSticky due to
behavior
by MRI. MRI returns nil instead of false when the sticky bit isn''t
supported on
a platform.
commit 37f8f4d9c78756da003ceca95f441d7286ae4aa4
Author: zacbrown <zac at zacbrown.org>
Date: Sat Apr 10 20:46:19 2010 -0700
Add support for ?G (grpowned?) in Kernel.test and add mspec test.
commit b78925082513a9d2f05a5f3b3010af09240e3e50
Author: zacbrown <zac at zacbrown.org>
Date: Sat Apr 10 20:45:47 2010 -0700
Add support for ?g (setgid) in Kernel.test and add mspec test.
commit 5915c6cbb3afd8ab4e05534756d179cdcda4f793
Author: zacbrown <zac at zacbrown.org>
Date: Sat Apr 10 20:45:17 2010 -0700
Add support for ?c (character device) in Kernel.test and add appropriate
ms
ec tests.
commit 501c33f9cc57d35e246235a2c8e9f6b3040960d7
Author: zacbrown <zac at zacbrown.org>
Date: Sat Apr 10 20:44:54 2010 -0700
Add support for ?C (ctime) in Kernel.test and add mspec test.
commit 0d38c595aa890c7f19e8d1df668cd9f85357a647
Author: zacbrown <zac at zacbrown.org>
Date: Sat Apr 10 20:44:06 2010 -0700
Add support for ?b (block device) in Kernel.test and add partial mspec
test
commit a0f06ec26d3981c5599ddbac947fa908b96270d2
Author: zacbrown <zac at zacbrown.org>
Date: Sat Apr 10 20:43:23 2010 -0700
Add support for ?A (atime) in Kernel.test and add appropriate mspec tests.
commit a9c673facc5d666870df4643c42ebcaa30d5644f
Author: hotgazpacho <will at hotgazpacho.org>
Date: Sat Mar 13 01:17:42 2010 -0500
Don''t assume MRI Ruby 1.8 is in my path. Be explicit about the
expectation
-------------- next part --------------
A non-text attachment was scrubbed...
Name: gitsync.diff
Type: application/octet-stream
Size: 16779 bytes
Desc: gitsync.diff
URL:
<http://rubyforge.org/pipermail/ironruby-core/attachments/20100603/2744b5ff/attachment.obj>
F2f with Tomas
JD
-----Original Message-----
From: Jim Deville
Sent: Thursday, June 03, 2010 2:15 PM
To: IronRuby External Code Reviewers
Cc: ironruby-core at rubyforge.org
Subject: Code Review: gitsync
tfpt review "/shelveset:gitsync;REDMOND\jdeville"
Comment :
sync from git:
commit 31501e7cac50ec624590d180b7da9fdec7d1a12f
Author: Jim Deville <jdeville at microsoft.com>
Date: Wed Jun 2 14:57:55 2010 -0700
moved gem shim to proper location
commit 4f252356198267c762f38f7d3cdef3944be7e564
Author: Ryan Riley <ryan at ryan-laptop.(none)>
Date: Fri Apr 16 23:03:38 2010 -0700
Updated rubyspecs for the Etc library.
Author: Ryan Riley <ryan at ryan-laptop.(none)>
commit c7f8951d4cdb09a5a4e1190a00bebc4f2cfc4581
Author: Jim Deville <jdeville at microsoft.com>
Date: Wed Jun 2 13:40:50 2010 -0700
Added the real etc.rb (oops) and correct passwd and getpwent specs.
Conflicts:
Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/librar
/etc/getpwent_spec.rb
Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/librar
/etc/passwd_spec.rb
commit d9c5c2c13742bd4c5490da415ac5b000e2fa7be0
Author: Ryan Riley <ryan at ryan-laptop.(none)>
Date: Sat Apr 10 08:05:59 2010 -0700
Added in the dev.sh and ir.sh scripts for mono. For some reason these
weren
t getting included in prior commits.
commit ceea1bb5db2f918d980e5b67a0a96cb185900883
Author: Ryan Riley <ryan at ryan-laptop.(none)>
Date: Sat Apr 10 07:47:48 2010 -0700
Added implementation of the Etc library, along with some updates to
RubySpe
. Also began work to fix file paths in testing facilities to allow tests to be
un on Mono.
Signed-off-by: unknown <jdeville at .redmond.corp.microsoft.com>
commit c38eef49ab93910c92d9aee94747e407ca5430f4
Author: Will Green <will at hotgazpacho.org>
Date: Tue May 25 03:23:34 2010 -0400
Gem::Platform objects, not strings, silly\!
commit 1755e7e33600fd6800a8a18f8cd7e764b9b1472d
Author: Will Green <will at hotgazpacho.org>
Date: Tue May 25 03:17:01 2010 -0400
Sigh. Need to explicitly add ''universal-unknown'' as a
platform, because rub
gems.org has not updated to rubygems 1.3.7 yet.
commit 7fa4051342b1c2574277ad52a8f929c9146840dd
Author: Will Green <will at hotgazpacho.org>
Date: Tue May 25 00:56:53 2010 -0400
Remove unnecessary platforms defaults
commit 0b3e45e7c6e18aec36dd01b4d378ac202823ccc6
Author: Will Green <will at hotgazpacho.org>
Date: Thu May 20 01:21:14 2010 -0400
report ruby, universal-dotnet, and universal-dotnet(FX-version) as
supporte
platforms
commit 8c0e99e482ccd097fa11a588f0f7150a84ad9f4a
Author: Will Green <will at hotgazpacho.org>
Date: Tue May 18 20:18:07 2010 -0400
Use gem defaults override to allow upgrading RubyGems
commit eeacc5b2becdc6f565383ac2f2cf9a0dd305ebb1
Author: zacbrown <zac at zacbrown.org>
Date: Sat Apr 10 20:47:51 2010 -0700
Add support for ?l (symlink) in Kernel.test and add mspec test.
commit f06a16eeb835f1409937cffc5acf3c039a81f0e3
Author: zacbrown <zac at zacbrown.org>
Date: Sat Apr 10 20:47:22 2010 -0700
Add support for ?k (sticky bit) in Kernel.test and add mspec test.
Requires
changes to the return value of RubyFileOps.RubyStatOps.IsSticky due to
behavior
by MRI. MRI returns nil instead of false when the sticky bit isn''t
supported on
a platform.
commit 37f8f4d9c78756da003ceca95f441d7286ae4aa4
Author: zacbrown <zac at zacbrown.org>
Date: Sat Apr 10 20:46:19 2010 -0700
Add support for ?G (grpowned?) in Kernel.test and add mspec test.
commit b78925082513a9d2f05a5f3b3010af09240e3e50
Author: zacbrown <zac at zacbrown.org>
Date: Sat Apr 10 20:45:47 2010 -0700
Add support for ?g (setgid) in Kernel.test and add mspec test.
commit 5915c6cbb3afd8ab4e05534756d179cdcda4f793
Author: zacbrown <zac at zacbrown.org>
Date: Sat Apr 10 20:45:17 2010 -0700
Add support for ?c (character device) in Kernel.test and add appropriate
ms
ec tests.
commit 501c33f9cc57d35e246235a2c8e9f6b3040960d7
Author: zacbrown <zac at zacbrown.org>
Date: Sat Apr 10 20:44:54 2010 -0700
Add support for ?C (ctime) in Kernel.test and add mspec test.
commit 0d38c595aa890c7f19e8d1df668cd9f85357a647
Author: zacbrown <zac at zacbrown.org>
Date: Sat Apr 10 20:44:06 2010 -0700
Add support for ?b (block device) in Kernel.test and add partial mspec
test
commit a0f06ec26d3981c5599ddbac947fa908b96270d2
Author: zacbrown <zac at zacbrown.org>
Date: Sat Apr 10 20:43:23 2010 -0700
Add support for ?A (atime) in Kernel.test and add appropriate mspec tests.
commit a9c673facc5d666870df4643c42ebcaa30d5644f
Author: hotgazpacho <will at hotgazpacho.org>
Date: Sat Mar 13 01:17:42 2010 -0500
Don''t assume MRI Ruby 1.8 is in my path. Be explicit about the
expectation