tfpt review "/shelveset:bindingandyamlfxcop;REDMOND\tomat" Comment : Kernel#binding captures receiver and eval uses it as "self". Adds FxCop configuration to yaml .csproj. Tomas -------------- next part -------------- A non-text attachment was scrubbed... Name: bindingandyamlfxcop.diff Type: application/octet-stream Size: 33256 bytes Desc: bindingandyamlfxcop.diff URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20100201/5322e6a5/attachment-0001.obj>
Basic test changes look good. Thanks for adding FXCop. Do we have specs for these changes? Or a bug so that I know what needs to be regressed? JD -----Original Message----- From: Tomas Matousek Sent: Monday, February 01, 2010 8:49 AM To: IronRuby External Code Reviewers Cc: ironruby-core at rubyforge.org Subject: Code Review: bindingandyamlfxcop tfpt review "/shelveset:bindingandyamlfxcop;REDMOND\tomat" Comment : Kernel#binding captures receiver and eval uses it as "self". Adds FxCop configuration to yaml .csproj. Tomas
I''ve added unit tests. There are probably no specs in Ruby suite. Note that 1.9 and 1.8 behaviors are different. Tomas -----Original Message----- From: Jim Deville Sent: Monday, February 01, 2010 10:49 AM To: Tomas Matousek; IronRuby External Code Reviewers Cc: ironruby-core at rubyforge.org Subject: RE: Code Review: bindingandyamlfxcop Basic test changes look good. Thanks for adding FXCop. Do we have specs for these changes? Or a bug so that I know what needs to be regressed? JD -----Original Message----- From: Tomas Matousek Sent: Monday, February 01, 2010 8:49 AM To: IronRuby External Code Reviewers Cc: ironruby-core at rubyforge.org Subject: Code Review: bindingandyamlfxcop tfpt review "/shelveset:bindingandyamlfxcop;REDMOND\tomat" Comment : Kernel#binding captures receiver and eval uses it as "self". Adds FxCop configuration to yaml .csproj. Tomas