fpt review /shelveset:regex;sborde Implements Kernel.srand with no parameters Changes RubyRegex to not clone the input string when being used for String#scan, and to share the cloned string when possible. Without the sharing, you could cause OutOfMemoryException. -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20091117/cf0d9ab5/attachment-0001.html> -------------- next part -------------- A non-text attachment was scrubbed... Name: regex.diff Type: application/octet-stream Size: 10027 bytes Desc: regex.diff URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20091117/cf0d9ab5/attachment-0001.obj>
Looks good. Tomas From: Shri Borde Sent: Tuesday, November 17, 2009 3:59 PM To: ironruby-core at rubyforge.org Cc: IronRuby External Code Reviewers Subject: Review: Fix fpt review /shelveset:regex;sborde Implements Kernel.srand with no parameters Changes RubyRegex to not clone the input string when being used for String#scan, and to share the cloned string when possible. Without the sharing, you could cause OutOfMemoryException. -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://rubyforge.org/pipermail/ironruby-core/attachments/20091118/10ea490a/attachment.html>