Jimmy Schementi
2009-Aug-02 03:57 UTC
[Ironruby-core] [Code Review] SP1 check should show the correct language name
http://github.com/jschementi/ironruby/commit/f615c36390b7af9d1479c4f54d74927eacbd45d4 Currently running ir.exe when the .NET framework is not installed prompts the user with the error message "IronPython requires .NET ..." This moves the check to where the display name of the console''s language is known. Does anything that runs before it depend on something post 2.0 SP1 but pre 3.5 SP1 so it would blow up before hitting this check? If so, is there a better way to get the language''s name, maybe from the assembly name? http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=1899.
Jim Deville
2009-Aug-05 20:50 UTC
[Ironruby-core] [Code Review] SP1 check should show the correct language name
Looks good. And it doesn''t blow up. JD ...there is no try http://blog.jredville.com> -----Original Message----- > From: Jimmy Schementi > Sent: Saturday, August 01, 2009 8:58 PM > To: ironruby-core at rubyforge.org > Cc: IronRuby External Code Reviewers > Subject: [Code Review] SP1 check should show the correct language name > > http://github.com/jschementi/ironruby/commit/f615c36390b7af9d1479c4f54 > d74927eacbd45d4 > > Currently running ir.exe when the .NET framework is not installed prompts > the user with the error message "IronPython requires .NET ..." This moves > the check to where the display name of the console''s language is known. > Does anything that runs before it depend on something post 2.0 SP1 but pre > 3.5 SP1 so it would blow up before hitting this check? If so, is there a better > way to get the language''s name, maybe from the assembly name? > > http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=1899.
Jimmy Schementi
2009-Aug-06 20:41 UTC
[Ironruby-core] [Code Review] SP1 check should show the correct language name
Great. It''s now in http://github.com/jschementi/ironruby/tree/master ________________________________________ From: Jim Deville Sent: Wednesday, August 05, 2009 1:50 PM To: Jimmy Schementi; ironruby-core at rubyforge.org Cc: IronRuby External Code Reviewers Subject: RE: [Code Review] SP1 check should show the correct language name Looks good. And it doesn''t blow up. JD ?there is no try http://blog.jredville.com> -----Original Message----- > From: Jimmy Schementi > Sent: Saturday, August 01, 2009 8:58 PM > To: ironruby-core at rubyforge.org > Cc: IronRuby External Code Reviewers > Subject: [Code Review] SP1 check should show the correct language name > > http://github.com/jschementi/ironruby/commit/f615c36390b7af9d1479c4f54 > d74927eacbd45d4 > > Currently running ir.exe when the .NET framework is not installed prompts > the user with the error message "IronPython requires .NET ..." This moves > the check to where the display name of the console''s language is known. > Does anything that runs before it depend on something post 2.0 SP1 but pre > 3.5 SP1 so it would blow up before hitting this check? If so, is there a better > way to get the language''s name, maybe from the assembly name? > > http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=1899.