Changes look good overall. I''m not sure that Type.IsProtected() is an intuitive name; maybe Type.IsNested() would be clearer? -----Original Message----- From: Tomas Matousek Sent: Saturday, June 06, 2009 12:51 PM To: IronRuby External Code Reviewers; Rowan Code Reviewers Cc: ironruby-core at rubyforge.org Subject: Code Review: ProGenFix tfpt review "/shelveset:ProGenFix;REDMOND\tomat" DLR, Python, Ruby. Fixes Ruby calls to protected generic methods. Adds CompilerHelpers.IsProtected() as an alias for IsFamily || IsFamilyOrAssembly. Tomas
You mean IsNestedProteced()? "Nested" feels superfluous since only nested types could be protected. Tomas -----Original Message----- From: Curt Hagenlocher Sent: Saturday, June 06, 2009 2:05 PM To: Tomas Matousek; IronRuby External Code Reviewers; Rowan Code Reviewers Cc: ironruby-core at rubyforge.org Subject: RE: Code Review: ProGenFix Changes look good overall. I''m not sure that Type.IsProtected() is an intuitive name; maybe Type.IsNested() would be clearer? -----Original Message----- From: Tomas Matousek Sent: Saturday, June 06, 2009 12:51 PM To: IronRuby External Code Reviewers; Rowan Code Reviewers Cc: ironruby-core at rubyforge.org Subject: Code Review: ProGenFix tfpt review "/shelveset:ProGenFix;REDMOND\tomat" DLR, Python, Ruby. Fixes Ruby calls to protected generic methods. Adds CompilerHelpers.IsProtected() as an alias for IsFamily || IsFamilyOrAssembly. Tomas
Ah, I see. Still, something strikes me as odd about the name, but I don''t feel strongly about it. -----Original Message----- From: Tomas Matousek Sent: Saturday, June 06, 2009 3:57 PM To: Curt Hagenlocher; IronRuby External Code Reviewers; Rowan Code Reviewers Cc: ironruby-core at rubyforge.org Subject: RE: Code Review: ProGenFix You mean IsNestedProteced()? "Nested" feels superfluous since only nested types could be protected. Tomas -----Original Message----- From: Curt Hagenlocher Sent: Saturday, June 06, 2009 2:05 PM To: Tomas Matousek; IronRuby External Code Reviewers; Rowan Code Reviewers Cc: ironruby-core at rubyforge.org Subject: RE: Code Review: ProGenFix Changes look good overall. I''m not sure that Type.IsProtected() is an intuitive name; maybe Type.IsNested() would be clearer? -----Original Message----- From: Tomas Matousek Sent: Saturday, June 06, 2009 12:51 PM To: IronRuby External Code Reviewers; Rowan Code Reviewers Cc: ironruby-core at rubyforge.org Subject: Code Review: ProGenFix tfpt review "/shelveset:ProGenFix;REDMOND\tomat" DLR, Python, Ruby. Fixes Ruby calls to protected generic methods. Adds CompilerHelpers.IsProtected() as an alias for IsFamily || IsFamilyOrAssembly. Tomas